Problem/Motivation

Composer modules have been updated already, most of the work is needed within updating configuration and ensuring that this can work on a D9 site with no issues.

Update composer to require orange_starter from drupal.org rather than github.

CommentFileSizeAuthor
#13 3177217-13.patch33.63 KBderekcresswell
#11 interdiff_11.txt4.17 KBPooja Ganjage
#11 3177217-11.patch31.28 KBPooja Ganjage
#9 3177217-9.patch33.86 KBPooja Ganjage
#7 3177217-7.patch23.63 KBPooja Ganjage
#6 interdiff.txt1.57 KBderekcresswell
#6 3177217-6.patch31.66 KBderekcresswell
#4 3177217-04.patch31.67 KBjoshmiller
#2 3177217-2.patch21.96 KBderekcresswell

Comments

DerekCresswell created an issue. See original summary.

derekcresswell’s picture

derekcresswell commented
Status: Active » Needs work
StatusFileSize
new 3177217-2.patch21.96 KB

Composer took a long time to cooperate, this should have all properly updated dependencies.

May need to add notice to readme that you need to install external libraries for this to work.

Need to update all configuration from config/install.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented 
  1. +++ b/composer.json
@@ -1,59 +1,52 @@
-    "drupal/config_inspector": "^1.0",
...
+    "drupal/config_inspector": "^1.0",

    Did we lose this module entirely?

    Oh I see it way down here. 

  2. +++ b/composer.json
@@ -1,59 +1,52 @@
+    "drupal/webform": "^6.0"

    This is a pretty major shift.

    I think the README should include a list of all contrib modules this profile uses.

    This is just a comment about follow up, not something we should tackle in the upgrade to D9 

  3. +++ b/orange_profile.info.yml
@@ -1,122 +1,116 @@
+description: 'Drupal install profile by Acro Media Inc.'

    I would recommend 'Orange install profile by Acro Media Inc.' 

  4. +++ b/orange_profile.install
@@ -149,16 +150,19 @@ function orange_profile_install() {
+      'type' => 'standard_content'
...
+      'type' => 'webform_content'

@@ -189,7 +192,9 @@ function orange_profile_install() {
+        'uri' => 'internal:/node/' . $node_contact_us->get('nid')->value

@@ -198,7 +203,9 @@ function orange_profile_install() {
+        'uri' => 'internal:/node/' . $node_contact_us->get('nid')->value

@@ -207,7 +214,9 @@ function orange_profile_install() {
+        'uri' => 'internal:/node/' . $node_contact_us->get('nid')->value

    Whitespace is weird in a lot of these places.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
StatusFileSize
new 3177217-04.patch31.67 KB

I think this is ready for commit. This may not close the issue, but it's much closer.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs work » Needs review
derekcresswell’s picture

derekcresswell commented
Version: » 2.0.x-dev
Status: Needs review » Needs work
StatusFileSize
new 3177217-6.patch31.66 KB
new interdiff.txt1.57 KB 
  • +++ b/composer.json
@@ -1,59 +1,60 @@
+    "drupal/comments_order": "^1.1",
+    "drupal/commerce": "^2.21",

    Are these supposed to be here? We could merge the ecom stuff in with the non but I thought that was not the plan.

  • It seems that CkEditor Media Embed is still causing problems. The latest release does not support Drupal 9.
    Removing it allowed composer to complete the installation. I'd be happy to see if we can provide some D9 patches for the module if it is necessary.

  • +++ b/composer.json
@@ -1,59 +1,60 @@
+    "drupal/core": "^9.0",

    Do we want this to support 8.8 as well?

    If not, the info.yml needs to change it's requirement.

  • When installing Drupal, I received the following error :

    An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /core/install.php?rewrite=ok&langcode=en&profile=orange_profile&id=1&op=do_nojs&op=do
StatusText: OK
ResponseText: Drupal\Component\Plugin\Exception\PluginNotFoundException: The "metatag_display_extender" plugin does not exist. Valid plugin IDs for Drupal\views\Plugin\ViewsPluginManager are: default in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /app/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

I've attached a patch with some minor fixes (not highlighted above).

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3177217-7.patch23.63 KB

Hi,

I am creating a patch as per #3 comments suggestions.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3177217-9.patch33.86 KB

Hi,

Creating a patch as per the #6 comments.

Please review the patch.

Let me know if any suggestions.

Thanks.

derekcresswell’s picture

derekcresswell commented
Status: Needs review » Needs work 
  1. +++ b/.gitignore
@@ -1,2 +1,3 @@
-.idea
\ No newline at end of file
+.idea
+composer.lock
\ No newline at end of file

    This is changed in patch #4 

  2. +++ b/README.md
@@ -3,10 +3,12 @@ CONTENTS OF THIS FILE
+ * Recommended modules
  * Installation
  * Configuration
  * Maintainers
 
+
 INTRODUCTION
 ============
 
@@ -29,6 +31,67 @@ This profile requires the following core:

@@ -29,6 +31,67 @@ This profile requires the following core:
 Drupal core ^8.8 || ^9
 
...
+RECOMMENDED MODULES
+===================

    This is not needed. The info is found in the .info file.

    Also does not use the up to date readme. You might want to run a git pull on your local repo. 

  3. +++ b/composer.json
@@ -1,59 +1,58 @@
+     "drupal/core-composer-scaffold": "^9",
+     "drupal/core-project-message": "^9",
+     "drupal/core-recommended": "^9",

    These are not supposed to be part of the profile. 

  4. +++ b/.gitignore
@@ -1,2 +1,3 @@
-.idea
\ No newline at end of file
+.idea
+composer.lock
\ No newline at end of file

    This is missing changes introduced in patch #6 

  5. +++ b/README.md
@@ -29,6 +31,67 @@ This profile requires the following core:
+RECOMMENDED MODULES
+===================

    This is not needed; the info is found within the .info file.

    Also this is not up to date with the current Readme. (File name and style) 

  6. +++ b/composer.json
@@ -1,59 +1,58 @@
+     "drupal/core-composer-scaffold": "^9",
+     "drupal/core-project-message": "^9",
+     "drupal/core-recommended": "^9",

    I don't think these are supposed to be here. Certainly not the project message. 

  7. +++ b/composer.json
@@ -1,59 +1,58 @@
+    "drupal/webform": "^6.0"

    Incorrect spacing. 

  8. +++ b/orange_profile.info.yml
@@ -1,124 +1,119 @@
+  themes:
+   - seven
+   - orange_starter

    This is tabbed in and errors on install.

Make sure to base your work off of the most recent patch and if you can include an interdiff for quick reviews : )

I also still received errors with metatag installing here.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3177217-11.patch31.28 KB
new interdiff_11.txt4.17 KB

Hi,

Creating patch as per the #10 comments and also included deprecated SPDX license version in composer file.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
derekcresswell’s picture

derekcresswell commented
StatusFileSize
new 3177217-13.patch33.63 KB

I notice now my comment #10 got messed up and posted stuff twice, apologies.

With this patch I was able to install a drupal site without errors. There are warnings due to missing libraries, sadly I don't think these can be automated.

I've changed the module namespaces within the info file, removed depreceated references to path.alias_storage, and updated a few minor modules to the correct versions. I have also added instructions to the read me to set up the theme properly.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs review » Fixed

Pushed the latest patch and gave both Derek and Pooja commit credit. Thanks everyone :)

I recognize this is the first step, there will likely be follow up issues that need addressed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.