In webform 6.x the setting 'form_remote_addr' has changed to 'form_disable_remote_addr'.
The install configuration of this module isn't compatible with this change.

There is also a not working unit test.

CommentFileSizeAuthor
#11 webform_iban_field-webform_multiple_check.patch538 bytesrik_deuzeman
#4 webform_iban_field-fixed_changed_webform_setting_and_unittest.patch3.16 KBrik_deuzeman
#2 renamed_changed_setting_form_remote_addr.patch558 bytesrik_deuzeman

Comments

rik_deuzeman created an issue. See original summary.

rik_deuzeman’s picture

rik_deuzeman commented
StatusFileSize
new renamed_changed_setting_form_remote_addr.patch558 bytes
rik_deuzeman’s picture

rik_deuzeman commented
Category: Bug report » Task
rik_deuzeman’s picture

rik_deuzeman commented
StatusFileSize
new webform_iban_field-fixed_changed_webform_setting_and_unittest.patch3.16 KB
joshahubbers’s picture

joshahubbers commented

Hello Rik,

Thank you for your patch. I will start a new version (2.x) with the new version numbering system. And add your patch to that version.

  • rik_deuzeman authored 2318f92 on 2.x 
    Issue #3176857 by rik_deuzeman, JoshaHubbers: Webform 6.x compatibility
joshahubbers’s picture

joshahubbers commented
Status: Active » Reviewed & tested by the community
joshahubbers’s picture

joshahubbers commented

Hello Rik

new rc has been made. Maybe you can verify it's correct working also? I tested it in a clean install and got no problems...

rik_deuzeman’s picture

rik_deuzeman commented

Hi Josha,

I have now used the 2.0.0-rc1 branch and it looks good! Thanks.

rik_deuzeman’s picture

rik_deuzeman commented

Josha,

One thing though, I don't know if it must be changed in the element class, but if you use IBAN in a composite element, the IBAN element doesn't get the '#webform_multiple' settings (only the #webform_composite_ settings). Now it will fail because of a notice (undefined index #webform_multiple). It can be fixed by adding the setting in prepare of the composite element, but it can also be fixed by checking the existence of this setting ($multiple = $element['#webform_multiple'] ?? FALSE).

rik_deuzeman’s picture

rik_deuzeman commented
StatusFileSize
new webform_iban_field-webform_multiple_check.patch538 bytes

Hmm.. it seems I can't fix it in the composite element. I have added a patch with an extra check on the #webform_multiple key.

  • rik_deuzeman authored d245579 on 2.x 
    Issue #3176857 by rik_deuzeman, JoshaHubbers: Webform 6.x compatibility
joshahubbers’s picture

joshahubbers commented

Thanx again Rik! Ik applied the patch, and created a new release: 2.0.0-rc2.

joshahubbers’s picture

joshahubbers commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.