Problem/Motivation

The only possibility to enable/disable a context is on context list page.
It would be nice to have a checkbox in the context edit form to enable/disable the context.

Proposed resolution

Create a field in the context edit form to provide this functionality.

CommentFileSizeAuthor
#10 3176682-10.patch1.31 KBpaulocs
#10 interdiff-8-10.txt1.25 KBpaulocs
#8 3176682-8.patch1.24 KBPooja Ganjage
#5 3176682-2.patch1012 bytesPooja Ganjage
#2 3176682-2.patch1.24 KBpaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
StatusFileSize
new 3176682-2.patch1.24 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3176682-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3176682-2.patch1012 bytes

Hi,

I am creating a patch for this issue.

Please review the patch.

Let me know for any suggestions.

Thanks.

Status: Needs review » Needs work

The last submitted patch, 5: 3176682-2.patch, failed testing. View results

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review

@Pooja Ganjage I already created a patch for it. See comment #2.
You can review it.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3176682-8.patch1.24 KB

Hi,

I have reviewed and patch applied successfully, but I update one change as coding standard fixes which is occur in #3 comment.

Thanks.

Status: Needs review » Needs work

The last submitted patch, 8: 3176682-8.patch, failed testing. View results

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-8-10.txt1.25 KB
new 3176682-10.patch1.31 KB

I found a bug when creating a context with the checkbox unchecked.

I attached a new patch.

Status: Needs review » Needs work

The last submitted patch, 10: 3176682-10.patch, failed testing. View results

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
deaom’s picture

deaom commented
Category: Task » Feature request
Status: Needs review » Reviewed & tested by the community

Tested the provided patch, and it's working. So marking this as RTBC, if this is something that would be usefull for other users, then it can be added, but this is more of a future request.

  • paulocs committed 86cd0f1 on 8.x-4.x 
    Issue #3176682 by paulocs, Pooja Ganjage, DeaOm: Add option to enable/...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.