[D8] Unique content field validation

Hi
Kindly fix the below errors

FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
259 | WARNING | Only string literals should be passed to t() where possible
285 | WARNING | Only string literals should be passed to t() where possible

I changed the issue priority as described on Review process for security advisory coverage: What to expect / Application Review Timelines.

Hello Fabian Sierra,

I have resolved the issue of literal strings and attached the patch over here. I have also installed the module and verified after code fixes.

Kindly have a look and implement the patch. We have pipeline in project which is getting affected due to this issue. So please apply patch ASAP as per your convenience.

Thanks
Vipin Mittal

RTBC +1

Actually, until the user who applied doesn't change the project files as reported, the status is still Needs work. The task of reviewers isn't providing patches, but reporting what needs to be changed.

      $message_item = !empty($element['#unique_field_settings']['message']) ? $element['#unique_field_settings']['message'] : '%label "%value" must be unique.';
      $items_msg = implode(',', $items);
      $message = t($message_item, ['%label' => $field_label, '%value' => $items_msg]);

Passing a variable as first argument of t() is considered a possible security issue.

Hello Fabian,

Could you please apply the patch of https://www.drupal.org/project/unique_content_field_validation/issues/32... to resolve the issue and make it security coverage of your module.

Thanks
Vipin

Added PAReview checklist in the issue description.

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, I didn't make a complete list of the lines that should be changed, but I made an example of what needs to be changed
• The review points report what should be changed to follow the Drupal coding standards, correctly use the Drupal API, or avoid any (possible) security issue; if a review point isn't about one of those topics, the point makes that clear

  private function uniqueValidation($field_name, $value, $entity_type, $bundle_field, $entity_bundle, $id_field) {
    if ($entity_type && $value && $field_name && $bundle_field && $entity_bundle) {
      $query = \Drupal::entityQuery($entity_type)
        ->condition($field_name, $value)
        ->condition($bundle_field, $entity_bundle)
        ->range(0, 1);
      // Exclude the current entity.
      if (!empty($id = $this->context->getRoot()->getEntity()->id())) {
        $query->condition($id_field, $id, '!=');
      }
      $entities = $query->execute();
      if (!empty($entities)) {
        return TRUE;
      }
    }
    return FALSE;
  }

When a validator constraint plugin needs to use dependencies, it needs to implement ContainerInjectionInterface, similarly to the following Drupal core plugin.

class ValidPathConstraintValidator extends ConstraintValidator implements ContainerInjectionInterface {

  /**
   * The path validator.
   *
   * @var \Drupal\Core\Path\PathValidatorInterface
   */
  protected $pathValidator;

  /**
   * Creates a new ValidPathConstraintValidator instance.
   *
   * @param \Drupal\Core\Path\PathValidatorInterface $path_validator
   *   The path validator.
   */
  public function __construct(PathValidatorInterface $path_validator) {
    $this->pathValidator = $path_validator;
  }

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static($container->get('path.validator'));
  }

  /**
   * {@inheritdoc}
   */
  public function validate($value, Constraint $constraint) {
    if (!isset($value)) {
      return;
    }
    $path = trim($value, '/');
    if (!$this->pathValidator->isValid($path)) {
      $this->context->addViolation($constraint->message, [
        '%link_path' => $value,
      ]);
    }
  }

}

        $form_state->setErrorByName($field_name, t('%message', [
          '%message' => $message,
        ]));

A string that only contains a placeholder cannot be translated, as a placeholder is the same for every language. A string that only contains two or more placeholders could be translated, as in that case the translation could at least change the placeholders order.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.