Problem/Motivation

// Tests exception in thrown when profile_fields tables does not exist. should be // Tests exception in thrown when profile_fields tables do not exist. in /core/modules/user/tests/src/Kernel/Migrate/d6/ProfileFieldCheckRequirementsTest.php and /core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php.

Proposed resolution

Replace "does" to "do", because the word "tables" is plural.

CommentFileSizeAuthor
#5 interdiff_3-5.txt1.27 KBraman.b
#5 3176036-5.patch1.41 KBraman.b
#3 3176036-3.patch1.41 KBpaulocs
#2 3176036-2.patch722 bytespaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Active » Needs review
StatusFileSize
new 3176036-2.patch722 bytes

A patch for it.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Issue summary: View changes
StatusFileSize
new 3176036-3.patch1.41 KB

New patch that includes the /core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php file

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

"exception in thrown" doesn't make sense, this should be "exception is thrown"?

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
StatusFileSize
new 3176036-5.patch1.41 KB
new interdiff_3-5.txt1.27 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • xjm committed 743cb62 on 9.2.x 
    Issue #3176036 by paulocs, raman.b, longwave: Replace "does" to "do" in...

  • xjm committed 7af06a3 on 9.1.x 
    Issue #3176036 by paulocs, raman.b, longwave: Replace "does" to "do" in...

  • xjm committed 58639a7 on 9.0.x 
    Issue #3176036 by paulocs, raman.b, longwave: Replace "does" to "do" in...

  • xjm committed 64154d9 on 8.9.x 
    Issue #3176036 by paulocs, raman.b, longwave: Replace "does" to "do" in...
xjm’s picture

xjm
she/her
Primary language English
commented
Title: Replace "does" to "do" in ProfileFieldCheckRequirementsTest.php » Docblock grammar fixes in ProfileFieldCheckRequirementsTest.php
Version: 9.1.x-dev » 8.9.x-dev

Thanks for the patch! We don't really have a way to scan for such grammatical errors.

Committed to 9.2.x, and backported to 9.1.x, 9.0.x, and 8.9.x as a patch-eligible documentation fix. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.