upgraded a customer site yesterday to 2.0-alpha1 and only tested orders with Klarna payment. What I didn't see, is that all other payment gateways are broken!!

Drupal\Core\Entity\EntityStorageException: Order ID not set

because updateOrderNumberOnPlace checks for ApiException | NonKlarnaOrderException, but a InvalidArgumentException is thrown. We have to changed that to NonKlarnaOrderException

CommentFileSizeAuthor
#2 3175948-2.patch491 bytesagoradesign

Comments

agoradesign created an issue. See original summary.

agoradesign’s picture

agoradesign commented
Status: Active » Needs review
StatusFileSize
new 3175948-2.patch491 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3175948-2.patch, failed testing. View results

  • tuutti committed 393f70a on 8.x-2.x authored by agoradesign 
    Issue #3175948 by agoradesign: 2.0-alpha1 breaks any other payment...
  • tuutti committed 969a270 on 8.x-2.x
    Merge branch '3175948' into '8.x-2.x'

Issue #3175948 by agoradesign: 2....
tuutti’s picture

tuutti commented
Status: Needs work » Fixed

Not sure how I let this slip past me. Thanks!

agoradesign’s picture

agoradesign commented

These tiny mis-types often happen during refactoring. Happens sometimes to me as well. And during development you are focused on that single project - that it might break other modules, is nothing you think of in this situation.

Thanks for this amazing fast reaction!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.