some coding standard errors in comment.module file, need to fix those errors.
FILE: /Users/qed42/Documents/sample/drupal_core/core/modules/comment/comment.module
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------
53 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
192 | WARNING | [x] There must be no blank line following an inline comment
442 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
556 | ERROR | [ ] Type hint "array" missing for $variables
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | After Patch.png | 284.07 KB | meena.bisht |
| #6 | Before Patch.png | 503.36 KB | meena.bisht |
| #4 | remove_errors-3175690-4.patch | 4.8 KB | meghasharma |
Comments
Comment #2
meghasharma commentedComment #3
meghasharma commentedComment #4
meghasharma commentedComment #5
meena.bisht commentedComment #6
meena.bisht commentedWhile reviewing I found some issues are yet to be solved . Adding Befor and after patch is applied screenshot . Putting it back to needs work .
Comment #7
meena.bisht commentedComment #8
alexpottThank you for your work on cleaning up Drupal core's code style!
In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core, stage 1. A good place to start is the child issues of #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard.
For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.
Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.
This should be closed as a duplicate.
Comment #9
meena.bisht commentedComment #11
NitinLama commentedwe can close this issue as per @alexpott.
Comment #12
quietone commentedClosing this as a duplicate based on the comment by alexpott in #8. Also, changing to Task.