Remove unused $admin_user variable in FieldEntityOperationsTest.php, views module

Thanks for researching this, I agree with your findings that we don't need this variable.

Patch applied cleanly.

RTBC!!!

If $admin_user isn't used, I don't think we need to create it at all.

@catch You're Right. I have Created new patch.

I have reviewed Patch #5 and applied cleanly.
$admin_user is not used anywhere and also we don't want to create the user.

Thanks @jijojoseph_zyxware for the patch.

RTBC!!!

+++ b/modules/views/tests/src/Functional/Handler/FieldEntityOperationsTest.php
@@ -66,11 +66,6 @@ class FieldEntityOperationsTest extends ViewTestBase {
-      'bypass node access',
-    ]);
     $this->drupalLogin($this->rootUser);
     $this->drupalGet('test-entity-operations');

Sorry looking at this in context I think there's another issue - we should be logging in as $admin_user instead of $this->rootUser for the test - then the variable will be used and we'll be testing what was intended. If the test fails with that change, we might need to adjust the permission (although it looks OK).

Addressed #8.
I think we need to update permissions as well.

Working on it.

As mentioned #8 added another permission and also changed '\Drupal\user\UserInterface' with '\Drupal\Core\Session\AccountInterface'.

+++ b/core/modules/views/tests/src/Functional/Handler/FieldEntityOperationsTest.php
@@ -66,12 +81,6 @@ public function testEntityOperations() {
-    $this->drupalLogin($this->rootUser);

Do we really need to do this in setUp() it's not like the is re-used anywhere? Why not just add the permission and do $this->drupalLogin($admin_user)?

I'll work on it.

Hear an updated patch.

@kapilkumar0324 if you are working in an issue you should assign it to your self, otherwise two people are working in the same issue and spend time with no reason (in that case I was working on it).

In my opinion it makes no sense to login in the setup() and I think @Lendude mentioned it in comment #14.
Another point is that now $adminUser in $this->drupalLogin($adminUser); is undefined so patch needs work.

For me it makes no sense to login in setup() but it is okay to create the user in setup().

I hide the files wrongly.

I'll provide a patch for it.

Patch and interdiff.

Hello, @paulocs your patch applied cleanly. Also, it satisfies the requirements as in #8 by @catch and #14 by @Lendude.

Also your explanation seems correct about the $this->drupalLogin($adminUser); as it needs to be changed.

Thanks for the patch!

RTBC

changing the status to RTBC.

This still seems needlessly complicated adding the user in setUp. Much smaller change to just use the existing variable. ¯\_(ツ)_/¯

Looks good too.

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!