Problem/Motivation

Follow up from #177124-72: Form validation messages appear in incorrect order

From @hgoto

The method name of the test case introduced in #55 is testLimitValidationErrors(). I used this name mistakenly and it's not proper for the content of the test. If possible, I'd like this to be adjusted.

Here is a trial patch. This patch expects that the previous patch was already applied.

Proposed resolution

Update method name to testValidationErrorMessagesSortedWithWeight()

Remaining tasks

  1. Confirm this change can still be made
  2. Review patch

Comments

pameeela created an issue. See original summary.

pameeela credited hgoto.

pameeela’s picture

StatusFileSize
new790 bytes

Patch from #177124-72: Form validation messages appear in incorrect order still applies. Added credit for @hgoto

pameeela’s picture

Status: Active » Needs review

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

tanubansal’s picture

Failed to apply patch #3 on 9.1
Please check

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

StatusFileSize
new806 bytes

Re-rolled for 9.4

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems like a simple test change.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, thanks!

  • catch committed b64011be on 10.1.x
    Issue #3175401 by pameeela, ranjith_kumar_k_u, hgoto: Update...
catch’s picture

pameeela’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.