[D10] Simple popups using webforms

Thank you for applying! Remember to change status as, in this issue queue, the Active status means the project is not yet ready to be reviewed.

I am crediting the users who participated in the previous application.

Hi

Kindly fix the below errors.

FILE: /var/www/pareviewd/pareview_temp/yxbgyjus/dopup.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
--------------------------------------------------------------------------

Time: 109ms; Memory: 6MB

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

FILE: ...areview_temp/yxbgyjus/src/Controller/DopupAutoCompleteController.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
63 | ERROR | Type hint "array" missing for $webform
64 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own line
--------------------------------------------------------------------------

FILE: ...www/pareviewd/pareview_temp/yxbgyjus/src/Plugin/Block/DopupBlock.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
26 | ERROR | [ ] Missing short description in doc comment
31 | ERROR | [ ] Missing short description in doc comment
36 | ERROR | [ ] Missing short description in doc comment
41 | ERROR | [ ] Missing short description in doc comment
206 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/pareviewd/pareview_temp/yxbgyjus/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
16 | WARNING | Line exceeds 80 characters; contains 81 characters
19 | WARNING | Line exceeds 80 characters; contains 97 characters
27 | WARNING | Line exceeds 80 characters; contains 98 characters
29 | WARNING | Line exceeds 80 characters; contains 117 characters
----------------------------------------------------------------------

FILE: /var/www/pareviewd/pareview_temp/yxbgyjus/dopup.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
8 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 277ms; Memory: 10MB

I changed the issue priority as described on Review process for security advisory coverage: What to expect / Application Review Timelines.

I am closing this application since there have been replies in the past 5 months.

Reviewing the code, the module seems to be pretty well written. While it does output a raw string in the template, that string is controlled from a settings page that has a protected permission behind it.

While I can nitpick a few things that need to be corrected (incorrect param argument in DopupAutoCompleteController::mapValueLabel(), missing comment on hook_theme, it uses jquery.cookie.js instead of core's js.cookie.min.js, update the README.md following the new guidelines), these could all be done as follow-ups in the issue queue.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.