The digest module utilises blocks as an easy way to send out newsletters to subscribed users. Schedules for digests are created using cron expressions. Users can subscribe and unsubscribe from their user/edit page.

Project link

https://www.drupal.org/project/digest

Git instructions

git clone --branch 1.0.x https://git.drupalcode.org/project/digest.git

Comments

DerekCresswell created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I had a look at this module at the request of Josh Millar.

This is my first project application review so I'm not that sure of the process.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs review » Needs work
derekcresswell’s picture

derekcresswell commented
Status: Needs work » Needs review

#3178409: Don't trust the output of CronTranslator::translate() was the only issue noted that had possible security implications and is now fixed in the latest versions.

The other noncritical issues reported by Alex are also underway.

Anything else needed from me? I'm happy to go around and see if I can do some reviews for other projects as well. : )

derekcresswell’s picture

derekcresswell commented
Status: Needs review » Reviewed & tested by the community

I guess this is supposed to be marked as RTBC? Alex Pott provided a review and the issues have been resolved since.

I don't think there should be any more issues so perhaps this is ready. If I'm mistaken on the RTBC then apologies, set it back to NR.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I agree with rtbc. I've reviewed the most recent changes and found a couple of improvements that can be made but they are not security related - they are:

derekcresswell’s picture

derekcresswell commented

Ah ok great! Thanks for the suggestions as well : )

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

derekcresswell’s picture

derekcresswell commented

Thank you so much Kiamlaluno!

I will look to review some projects from the queue here soon : )

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.