Problem/Motivation

When Slack module is enabled, but not configured, checking the Slack notification box can lead to an error.

Error: Call to a member function addError() on null in Drupal\slack\Slack->sendMessage() (line 84 of modules/contrib/slack/src/Slack.php).

Proposed resolution

Check if Slack is enabled AND properly configured

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3174300-2.patch1.21 KBdspachos

Comments

dspachos created an issue. See original summary.

dspachos’s picture

dspachos commented
StatusFileSize
new 3174300-2.patch1.21 KB

Quick fix attached

  • fjgarlin committed df8b2d2 on 8.x-1.x authored by dspachos 
    Issue #3174300 by dspachos: Slack module enabled check must also check...
fjgarlin’s picture

fjgarlin commented
Status: Active » Fixed

Well spotted @dspachos, thanks so much for the patch! Already committed.

fjgarlin’s picture

fjgarlin commented
Status: Fixed » Closed (fixed)