There is som errors in the composer.json file

Suggestions

Line 2:
"name": "drupal/view_user_email",

Line 5:
Type is set in line 3 so this line can be deleted.

Line 19:
Delete comma ,

The file should look like this.

{
"name": "drupal/view_user_email",
"type": "drupal-module",
"description": "Allow site administrator the ability to grant users of certain roles access to another users email address.",
"keywords": [
],
"homepage": "https://www.drupal.org/project/view_user_email",
"minimum-stability": "dev",
"authors": [
{
"name": "David Loor (davo20019)",
"homepage": "https://www.drupal.org/u/davo20019",
"role": "Maintainer"
}
],
"support": {
"issues": "https://www.drupal.org/project/issues/view_user_email",
"source": "http://cgit.drupalcode.org/view_user_email"
},
"require": {
"drupal/core": "^8.0.0 || ^9"
}
}

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

styrbaek created an issue. See original summary.

styrbaek’s picture

StatusFileSize
new802 bytes

I have created a patch for this issue.
My first patch so I am not sure if I am doing it right.

styrbaek’s picture

Issue summary: View changes
ant1’s picture

Status: Active » Reviewed & tested by the community

The patch applies perfectly and seems to fix the warnings I'm receiving.
Setting to RTBC (as it is a simple fix)!

davo20019’s picture

Thanks styrbaek!

attheshow’s picture

Thanks for the patch! Seems to apply cleanly.

neerajsingh’s picture

StatusFileSize
new511.56 KB

Thank you styrbaek..!
Patch is clean and works for me too. +1 to RTBC.
clean-patch

p4trizio’s picture

+1 to RTBC

davo20019’s picture

tijsdeboeck made their first commit to this issue’s fork.

tijsdeboeck’s picture

I've added patch #2 to empty merge request !1. Can we please get this merged, as it's such a simple patch, and has been in use for over 2 years!

  • davo20019 committed d837f66 on 1.0.x
    Issue #3174011 by styrbaek, tijsdeboeck, davo20019, neerajsingh: Errors...
davo20019’s picture

davo20019’s picture

Version: 1.0.1 » 1.0.2
Assigned: Unassigned » davo20019
Status: Reviewed & tested by the community » Fixed
tijsdeboeck’s picture

Hi @davo20019, thanks for committing this! I noticed that @antoineh didn't receive a credit, while he was the first to review the patch.

(full disclosure: antoineh is my colleague, that's why I noticed this, but it seems fair, as neerajsingh also received a credit for testing)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.