Problem/Motivation
The context parameter of error handlers has been deprecated in PHP 7.2 and relying on it is discouraged - see https://www.php.net/manual/en/function.set-error-handler.php
Proposed resolution
Remove context argument from custom error handers in tests
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
N/a
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3173888-6.patch | 4.15 KB | andypost |
| #6 | interdiff.txt | 1.67 KB | andypost |
| #2 | 3173888-2.patch | 2.48 KB | alexpott |
Comments
Comment #2
alexpottExtracted from #3156595: Make Drupal 9 installable on PHP8
Comment #3
andypostComment #5
andypostrequeued, unrelated failure
QuickEditIntegrationTestComment #6
andypostNot sure about deprecation process here but both
_drupal_error_handler()and_drupal_error_handler_real()using this argument but does not consume it (unused variable)Comment #7
alexpottYep changing that makes sense. I wonder why it's not causing deprecations - but no matter. The change is fine I think.
Comment #8
gábor hojtsyWe are not using $context for anything and not passing it into an extension point (eg. custom error handler), so this does not change our API. Looks good.
Comment #10
catchCommitted e9969b0 and pushed to 9.1.x. Thanks!