October 5, 2020 - Meeting Agenda [#3173586]

Meeting Agenda

Introductions
Status
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!This meeting:• happens every Monday at 2pm GMT (10am ET).• is chat only (no audio or video).• happens in threads so keep an eye on those notifications.• there are about 5-10 minutes between topics for people who are multitasking to follow along.• the agenda is public and anyone can add to it:#3173586: October 5, 2020 - Meeting Agenda• :star: The transcript of this meeting will be exported and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.0️⃣ If you’re attending this meeting, please 1) Let us know here, and 2) comment in the meeting agenda issue above so we can give issue credit on d.o

mherchel	:sunrise: Morning! @mtift (he/him) said he’s gonna be a bit late, so I’ll be running today’s meeting
hansa11	Hello everyone! :wave:
lauriii	Hello :wave:
proeung	Happy Monday! :wave:
Gábor Hojtsy (he/him)	:wave:
brianperry	Hello!
thejimbirch	:wave:
jackh	Hey there
Ruchi	Hii all!
ambuj_gupta	Hello
sd9121	Hello
shaal	Joining late
larowlan	lee, late

1️⃣ Overall Project Status

mherchel	Meta issue is at #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta
mherchel	Overall, lots of progress is being made!
mherchel	Any of the beta-blocking issues have been resolved (2 left), including the XSS bug
mherchel	I’ve personally been doing lots of testing, and been fixing various visual issues (even re-tested the Forum module and found/fixed a bug)
mherchel	We still need help with the remaining issues (which are more backend type tasks), but I will talk about them later
proeung	Amazing progress! Awesome job everyone and especially @mherchel for reviewing and putting the hours this last weekend!

2️⃣ Individual issue discussion

mherchel	@brianperry do you need additional help on the automated tests (#3174105: Fix tests for Olivero in core patch) ?
mherchel	Unrelated to :point_up: I’ve been playing with making the Olivero sidebar sticky using postition-sticky #3174774: Enable option to "sticky" the sidebar within Olivero
mherchel	Would love thoughts on that
brianperry	My plan was to give it one more shot today (keep getting closer, but not close enough) But totally wouldn't be insulted if someone jumped in given the priority.
mherchel	Cool. I appreciate you working on this! Ping me when you get your latest patch, and I’ll generate a new core patch and queue it up. If that fails, I’ll reach out for help
brianperry	Sounds good - thanks for the patience while I learn lessons about the differences between running these tests in core and contrib :slightly_smiling_face:
mherchel	Unrelated to all of :point_up: the other beta blocker is #3174075: Both olivero_theme_suggestions_block_alter and olivero_preprocess_block should NOT load block by ID,. I’m unsure how to resolve this, if anyone has ideas. if not larowlan said he’d help me out tomorrow
Gábor Hojtsy (he/him)	@mherchel what’s in the 16 item “elements” array?
Gábor Hojtsy (he/him)	I looked at all the core hook_preprocess_HOOK implementations for “block” but did not find that the block object was provided, although that does not mean it is not :slightly_smiling_face:
mherchel	Will check when I finish up this meeting
mherchel	@Gábor Hojtsy (he/him)
Gábor Hojtsy (he/him)	Yeah no
Gábor Hojtsy (he/him)	I wonder if @larowlan mixed this up with something else? :slightly_smiling_face: Or he may know something we don’t :smile: I don’t think I ever used this hook, so don’t really know what to expect from it.
mherchel	Evidently it’s a holiday in Australia. I’ll reach out to him tomorrow
larowlan	hey I’m here
larowlan	we’re using Block::load but looking at the call to ‘#theme’ => ‘block’ in block view builder, the block is available as #block
larowlan	I can work on this issue
larowlan	Opened #3175051: See if we can leave the block around in BlockViewBuilder::preRender so front-end themes can make use of it because we’re unsetting ‘#block’ in core, but I don’t see why we need to - if themes want/need it :thinking_face: (edited)
mherchel	Appreciate the help! I’ll be in and out tonight adn prob go to sleep in about 4 hours :slightly_smiling_face:
larowlan	no worries, if that comes back green I’ll see if I can chase up a review and then maybe we can ask Gabor to help too, as I can’t commit it having worked on it
larowlan	patch on that came back red/green i’ll see if I can chase up a review

3️⃣ Where can people help this week?

mherchel	We previously mentioned the final beta blockers:#3174075: Both olivero_theme_suggestions_block_alter and olivero_preprocess_block should NOT load block by ID,
mherchel	If you’re a back-of-the-front-end type person, they might be right up your alley. If not, we’ll reach out for help and get them done.
mherchel	In addition to those high priority issues, there are many coding standards issues (some easy and some not) that need to be resolved
mherchel	beyond that, most testing would be appreciated! Especially non-standard browsers such as Samsung, Opera, IE11, etc.