Closed (fixed)
Project:
Drupal core
Version:
10.0.x-dev
Component:
image system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Sep 2020 at 19:28 UTC
Updated:
13 Jul 2022 at 14:19 UTC
Jump to comment: Most recent
Comments
Comment #2
andypostComment #4
andypostComment #6
mondrakeComment #9
spokjeComment #10
mondrakeCommented on the MR
Comment #11
quietone commentedSetting to NW for the unresolved items
Comment #12
andypostClosed as duplicate #3179058: Remove ToolkitGdTest::testResourceDestruction() when core require PHP 8.0
Comment #13
andypost@mondrake Nice idea! I filed follow-up to change naming #3265953: Deprecate resource mentions in GDToolkit method names
added commit to remove unrelated hunk and rebased MR
Comment #14
mondrakeComments in MR
Comment #15
andypostComment #16
spokjeThis is as far as I can take this one. I don't understand the remaining two open remarks on the MR.
Comment #17
andypostI think deprecation should be separate issue as it could go only into 10.1.x
Comment #18
andypostFiled follow-up #3292531: Rename GDToolkit::resource as it object since PHP 8.0 the rest looks ready
Comment #19
alexpottCommitted and pushed 7f337ca7b1 to 10.1.x and 54a3f55501 to 10.0.x. Thanks!