Problem/Motivation

In core/modules/rest/src/Routing/ResourceRoutes.php, $supported_formats variable never used.

CommentFileSizeAuthor
#3 3172846-3.patch848 bytesPooja Ganjage
#2 3172846-2.patch855 bytesshetpooja04
#2 unused_variable.png555.71 KBshetpooja04

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
StatusFileSize
new unused_variable.png555.71 KB
new 3172846-2.patch855 bytes

Commit ID: 871da5e4

Link: https://git.drupalcode.org/project/drupal/-/commit/871da5e4f723b5b1928956c495a0f148e4cbbaff

File: core/modules/rest/src/Routing/ResourceRoutes.php Line: 93

For Issue: https://www.drupal.org/project/drupal/issues/2308745 the variable is added but not used

Please review

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172846-3.patch848 bytes

Hi,

@shetpooja04, I have reviewed your patch and you seems to put all && conditions together.

I am creating updated patch.

Please review this patch.

Let me know for any recommendations.

Thanks.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented

@Pooja Ganjage (#3 patch)
if condition was added in incorrect way, #2 patch looks to me
Thanks

chaithanya.m’s picture

chaithanya.m commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the Patch #2. The variable $supported_formats is never getting used in ResourceRoutes.php It is working fine without this variable.

The last submitted patch, 2: 3172846-2.patch, failed testing. View results

  • catch committed a5c9c32 on 9.1.x 
    Issue #3172846 by shetpooja04, Pooja Ganjage, naresh_bavaskar,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed a5c9c32 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone credited alexpott.

quietone credited antojose.

quietone credited himanshu_sindhwani.

quietone credited jungle.

quietone credited mradcliffe.

quietone credited nijolawrence.

quietone credited rpayanm.

quietone’s picture

quietone commented
Related issues: +#3157984: Unused variables in Rest module

Closed earlier issue #3157984: Unused variables in Rest module as a duplicate and adding credit.