Problem/Motivation

PHP 7.4 is coming!

Steps to reproduce

Build the latest version of Panopoly. Run phpcs on the contrib modules directory with the PHP compatibility set to 7.4.

Proposed resolution

All of the issues identified so far have patches available. Add those patches to the Panopoly Core makefile.

Remaining tasks

Patch - attached
Automated tests
Manual testing

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 panopoly-php74-3172485-5.patch7.73 KBdsnopek
#4 panopoly-php74-3172485-4.patch6.11 KBdsnopek
#3 panopoly_core-php74-3172485-3.patch2.25 KBcboyden
#2 panopoly_core-php74-3172485-2.patch2.15 KBcboyden

Comments

cboyden created an issue. See original summary.

cboyden’s picture

cboyden commented
Assigned: cboyden » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new panopoly_core-php74-3172485-2.patch2.15 KB
cboyden’s picture

cboyden commented
StatusFileSize
new panopoly_core-php74-3172485-3.patch2.25 KB

Added another patch for Field Group.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly-php74-3172485-4.patch6.11 KB

Here is a profile patch that includes the changes from #3, but also some changes to our Travis CI configuration, so that our tests run on PHP 7.3 and 7.4.

EDIT: Here's a build with this patch on Travis CI: https://travis-ci.org/github/panopoly/panopoly/builds/730038463

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly-php74-3172485-5.patch7.73 KB

Here's a new profile patch, which I'm hoping will actually pass tests this time!

EDIT: Here's the Travis build: https://travis-ci.org/github/panopoly/panopoly/builds/733112275

  • dsnopek committed 2f756e1 on 7.x-1.x 
    Issue #3172485 by cboyden, dsnopek: Patch contrib modules for PHP 7.4
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tests finally passed! Committed :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.