Problem/Motivation

When installing the module, Drupal crash with this error when comment is not installed.

Configuration objects provided by group_notify have unmet dependencies: core.entity_view_mode.comment.group_notify_email (comment)

Steps to reproduce

Try to install the module on a website where the comment module is disabled with drush en group_notify for example.

Proposed resolution

Add the dependency on the comment module.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 group_notify-crash_install-3172308-2.patch242 bytesphjou

Comments

phjou created an issue. See original summary.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new group_notify-crash_install-3172308-2.patch242 bytes
gregcube’s picture

gregcube commented

I'm thinking about this... Because comment notifications are optionally enabled, we shouldn't make this a hard dependency. It's probably a better idea to only install this configuration (core.entity_view_mode.comment.group_notify_email) when comment notifications are enabled. And of course uninstall the configuration when comment notifications are disabled.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs review » Needs work
gregcube’s picture

gregcube commented

Looks like it is as easy as moving core.entity_view_mode.comment.group_notify_email.yml from /config/install to /config/optional

Thanks for reporting this.

  • gregcube committed 64486b7 on 8.x-1.x 
    Issue #3172308 by phjou: Missing dependency on comment module
gregcube’s picture

gregcube commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.