September 28, 2020 - Meeting Agenda [#3172228]

Meeting Agenda

Introductions
Status
CSS Refactoring
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3172228: September 28, 2020 - Meeting Agenda

mherchel	Morning! :sunrise:
Gábor Hojtsy (he/him)	Heyo!
kiran.kadam911	Hello Everyone! :slightly_smiling_face:
hansa11	Hello everyone! :wave:
komal k	Hello Everyone!
katannshaw	Hello
sd9121	Hello
jackh	Good morning!
proeung	Good morning/afternoon!
naresh_bavaskar	Hello all
lauriii	:wave:
shaal	:wave:

Lots of progress, refactoring, and minor bug cleanup. We’re very close to meeting our beta criteria (after adding the issue to refactor CSS to utilize post-css-env)

mherchel	We had a CSS review from Lauri last week. Found a number of issues… but nothing blocking the addition to Drupal core as beta
mherchel	Putra broke the feedback down into multiple issues. From what I gather, they’re mostly syntactical (wrong BEM naming, etc)
proeung	Indeed! Also, all of those CSS review issues can be found here - #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta#comment-13836109
Gábor Hojtsy (he/him)	my understanding is @larowlan is planning to do a (backend) framework manager review
mherchel	Nice!
mherchel	yeah, all types of reviews would really be helpful now. Still lots to do, but we don’t want any last minute “gotchas”
katannshaw	We received the low vision test results back from NFB in a video which you can watch at https://zoom.us/rec/share/G-1w9HjT0tUlWhoJnGkmlqspVFfsxSr97Dl7077fkIgGfA... Their communications team is working on a summary for us to share via social media. (edited)
mherchel	Yep. that’s all good news. I was (almost) kinda disappointed that they didn’t find anything that we could fix!
Gábor Hojtsy (he/him)	Well, that’s quite important as 9.1 will be in alpha freeze in less than 3 weeks :smile:
Gábor Hojtsy (he/him)	so better get stuff in now :smile:
Gábor Hojtsy (he/him)	I’ve pinged the two release managers if either have time to review :slightly_smiling_face:
proeung	Oh man! the deadline to get Olivero into 9.1 is creeping up. @Gábor Hojtsy (he/him) If we can get more release managers to review our patch this week that would be awesome!
Gábor Hojtsy (he/him)	Yeah its either c_atch or x_jm, I pinged them in committer slack.
Gábor Hojtsy (he/him)	If you can get the testing results posted on the issue + any supporting words from the Drupal accessibility team, that would be superb.
katannshaw	Absolutely. I've been gently pushing for them to send them to us as quickly as possible. They were delayed on their side for some reason but they seem to be coming along now. I do know that the low vision tester said that Olivero also passed screen reader testing. I'll post the low vision test results to the issue queue today. (edited)
proeung	Awesome and thanks @katannshaw!
Gábor Hojtsy (he/him)	@proeung @mherchel also you should clear out any of the “Needs” tags that are in your own field; “Needs issue summary update” and “Needs tests”
mherchel	:thumbsup:
mherchel	Doing so now
Gábor Hojtsy (he/him)	btw c_atch posted a comment already, but did not remove the release manager review tag and x_jm indicated that from her point of view the rest of the reviews should be in before she looks
mherchel	k. Let me know if there’s anything additional that I need to do.
Gábor Hojtsy (he/him)	@mherchel are you seeing anything that would need to be pointed out as per c_atch’s comment? (edited)
mherchel	Nope.
mherchel	want me to respond in the issue?
Gábor Hojtsy (he/him)	Yes
Gábor Hojtsy (he/him)	Otherwise it looks like an unanswered question :)

2️⃣ CSS Refactoring

mtift (he/him)	Factoring was not totally effective so we're thinking about refactoring :wink:
mherchel	lol
mherchel	So, the entire CSS codebase has been refactored. There’s a new PostCSS going into core https://github.com/csstools/postcss-preset-env
mherchel	It enables us to utilize new and upcoming CSS features that have not yet made it into all browsers
proeung	Here's the link to the Core issue - #3170864: Add postcss-preset-env
mherchel	There’s some differences in how you write the CSS, and I documented them at https://www.drupal.org/docs/contributed-themes/olivero/authoring-css-for...
mherchel	But the best thing to do (at least until you’re familiar w the new syntaxes) is to double check the compiled CSS
proeung	@mherchel Major :heavy_plus_sign: for creating this documentation for authoring CSS for Olivero!
mherchel	In addition to that, I’d love to have additional real world testing of almost everything (especially interactive components) to make sure there are no regressions
mherchel	I used Tugboat’s visual diff feature to make sure there were no visual regressions when logged out, but that only takes static shots of the default state
mherchel	so, more user testing is really needed

3️⃣ Individual issue discussion

mtift (he/him)	Do your issues have questions? We've got answers! Let's discuss.
mherchel	I would love to have a backend person figure out the best way to handle #3172696: Search API-made exposed forms are not styled within Olivero
mherchel	we don’t want to support the module specifically, but if we could make it easy for the module to support us, that’d be awesome

4️⃣ Where can people help this week?

mtift (he/him)	Share your suggestions here
proeung	We have several tickets added to the issues queue based on the CSS feedback that we've received from one of the release managers. Please take a look at this list and feel free to grab any of these issues. https://www.drupal.org/project/issues/olivero?status=1&version=8.x-1.x-d...
mherchel	And we need lots of regression testing. With the major CSS refactor, more things are going to be out there
proeung	Indeed! @mherchel We can enable automatic visual diffs in Tugboat if the base preview hasn’t been rebuilt yet.
mherchel	base preview has been rebuilt, but yeah, I’ve already done all the automated visual diff stuff
mherchel	I’m more concerned about interactive components that that will not catch, and logged in components (like layout builder interface stuff)
proeung	Makes sense

Participants:

mherchel, Gábor Hojtsy (he/him), kiran.kadam911, hansa11, komal k, katannshaw, sd9121, jackh, proeung, naresh_bavaskar, lauriii, shaal, mtift (he/him)