Problem/Motivation

Tests for name stopped passing on 13th August (see https://www.drupal.org/pift-ci-job/1700584). This prevents CI from successfully running for all patches submitted (or commits made) after this date.

This is happening because when the tests were ported from simpletest to phpunit, they weren't moved to the correct directory structure for phpunit to be able to pick them up/

Steps to reproduce

Run drupal CI for this module.

Proposed resolution

Either migrate the tests over to phpunit, or I think you can add an additional step to enable simpletest to drupalci.yml as per https://www.drupal.org/node/3112907

Move the tests from src/Tests to tests/src/Functional

Comments

JeremySkinner created an issue. See original summary.

jeremyskinner’s picture

Title: Phpunit tests for name no longer pass » Tests for name no longer pass
jeremyskinner’s picture

Issue summary: View changes
jeremyskinner’s picture

StatusFileSize
new2.58 KB

Here's a patch that adds a drupalci.yml as suggested in https://www.drupal.org/node/3112907. Let's see if that works... Edit: Apparently not...

jeremyskinner’s picture

StatusFileSize
new2.24 KB

Ah, no the issue was that the tests had already been migrated from simpletest to phpunit, but they hadn't been moved into the correct directories. DrupalCI made a change to generate an error when no tests could be found (rather than silently continuing as it used to). Attached patch moves tests into correct directory structure so they can be found by phpunit.

jeremyskinner’s picture

StatusFileSize
new3.49 KB

Also fix incorrect namespace in trait

jeremyskinner’s picture

Issue summary: View changes
jeremyskinner’s picture

StatusFileSize
new3.86 KB
jeremyskinner’s picture

StatusFileSize
new3.77 KB
jeremyskinner’s picture

Tests are now all passing.

jeremyskinner’s picture

Status: Active » Needs review

nkoporec’s picture

Status: Needs review » Fixed

commited, thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.