[9.1] Declaring ::setUp without a void return typehint is deprecated (Rules)

Thanks Pooja, that's great. Good to see it runs OK at 8.8.

However, we need to check the deprecations at core 9.1. To do this, please can you make a new patch with everything from #3 plus the creation of the new file drupalci.yml as in patch #24 from #3089502-24: [meta] Rules deprecated code (you can take that patch #24 and append it to yours). Then test it at core 9.1. There will be other failures, due to other deprecations, but we can see if this particular message is removed with your changes.

Jonathan

Hi Pooja,
Your patch #9 has modules/contrib/rules/ before every file name. This is wrong, as the patch is applied from within the Rules root folder. You patch in #6 was much closer to being correct. If you look at the test result for that patch, you can see the error

error: drupalci.yml: No such file or directory

The drupalci.yml file does not exist, and this patch should be creating the file. In the 3089502-24.show_deprecations_via_drupalci.patch you can see

--- /dev/null
+++ b/drupalci.yml

whereas your patch has a/drupalci.yml instead of /dev/null. So, I suggest you go back to patch #6 and change it to /dev/null and forget #9. Hope that helps.

Thank you @msuthars, this looks good on first viewing. I have now queued it for testing at core 9.1 because that is where the deprecations are produced. This test will fail as there are other deprecations, but it should show that the ':setUp without a void return' message has been solved.

This is good. You can see in Patch #15 test https://www.drupal.org/pift-ci-job/1836908 that there are no "void" messages and we get 272 pass, 19 fail. On the existing codebase Patch #24 on the meta issue https://www.drupal.org/pift-ci-job/1832280 there are many "void" messages and the numbers at the top show 71 pass, 82 fail.

It's unfortunate that the drupal.org testbot output does not have a simple summary consolidating the deprecation messages, but I can show via Travis testing that the deprecations have dropped from 863 to 566, i.e. all 297 'void typehint' are solved by this patch.

Patch #17 makes the identical code changes, but has the drupalci.yml file removed, and the necessary changes to .travis.yml added, so this is ready for committing.

Patch #18 only changes .travis.yml to cater for a new 13x deprecation which was committed to core 9.1 today. I will raise a Rules issue in due course, but good to get the travis tests passing with this.

Thanks @Pooja Ganjage, @msuthars and @TR