Problem/Motivation

$ phpcs --standard=DrupalPractice --extensions=json,php,module,inc,install,test,profile,theme,css,info,txt,md,yml /var/www/html/web/modules/contrib/cloud

FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Service/CostFieldsRenderer.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#2 3171934-2.patch2.05 KBsekinet

Comments

onotm created an issue. See original summary.

sekinet’s picture

sekinet commented
Assigned: onotm » sekinet
Status: Active » Needs review
StatusFileSize
new 3171934-2.patch2.05 KB

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for fixing the issue. It looks good to me. I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 568462a on 8.x-1.x authored by sekinet 
    Issue #3171934 by sekinet, yas: Use DI in CostFieldsRenderer

  • yas committed e1e8964 on 8.x-2.x authored by sekinet 
    Issue #3171934 by sekinet, yas: Use DI in CostFieldsRenderer

  • yas committed d04ab80 on 3.x authored by sekinet 
    Issue #3171934 by sekinet, yas: Use DI in CostFieldsRenderer
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.