Problem/Motivation

The "Add to the selected roles only" work incorrectly.

Steps to reproduce

Install the module and configure it to only track anonymous users on the site via the UI by using "User role tracking" and this configuration.
Current: authenticated users get tracked also.
Expected: only anonymous users get tracked.

Proposed resolution

See the attached patch.

CommentFileSizeAuthor
#2 adobe_analytics-fix-inclusive-tracking-logic-3171800-2.patch866 bytesmxr576

Issue fork adobe_analytics-3171800

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mxr576 created an issue. See original summary.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new adobe_analytics-fix-inclusive-tracking-logic-3171800-2.patch866 bytes

m4olivei made their first commit to this issue’s fork.

m4olivei opened merge request !6

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei
Status: Needs review » Needs work

The patch no longer applie, plus we could use some tests for this. I still see this as an issue.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Needs work » Reviewed & tested by the community

There we go! Tests should cover us well for the pair of config at play here. Also confirmed the bug is fixed in Tugboat.

  • m4olivei committed 12f974e on 8.x-1.x 
    Issue #3171800 by m4olivei, mxr576: "Add to the selected roles only"...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x. Thanks @mxr576!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.