Followup from #3171156: How to handle new core "wide" image style within article content type

After core inclusion, but before we make this the default core theme, we need to remove the hard-coding of the image style within the article content type's full view mode.

CommentFileSizeAuthor
#5 3171570-5.patch826 byteskostyashupenko

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Remove custom hard-coding of the image style within article content type's full view mode » Remove Olivero's custom hard-coding of the image style within article content type's full view mode
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 10.0.x-dev
Component: Code » Olivero theme
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 10.0.x-dev » 9.3.x-dev
catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Active

If this was postponed due to Olivero not being in core yet, it can probably be un-postponed now.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Postponed
Related issues: +#3171149: Set article content type to use "wide" image style within standard profile
StatusFileSize
new 3171570-5.patch826 bytes

https://www.drupal.org/project/drupal/issues/3153009 this task was merged, but this one is still not https://www.drupal.org/project/drupal/issues/3171149

So without hardcode right now attached image style will be "Large". I'll prepare the patch for now, but can not be merged since blocked by related task.

Postponing

catch’s picture

catch
he/him
Primary language English
commented
Title: Remove Olivero's custom hard-coding of the image style within article content type's full view mode » [PP-1] Remove Olivero's custom hard-coding of the image style within article content type's full view mode
catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical

Bumping to critical since this blocks making Olivero the default theme. Still blocked on #3171149: Set article content type to use "wide" image style within standard profile.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Postponed » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Patch in #5 still works and looks good!

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Remove Olivero's custom hard-coding of the image style within article content type's full view mode » Remove Olivero's custom hard-coding of the image style within article content type's full view mode

  • catch committed afdff8f on 9.4.x 
    Issue #3171570 by kostyashupenko, mherchel: Remove Olivero's custom hard...

  • catch committed 2eec3dc on 9.3.x 
    Issue #3171570 by kostyashupenko, mherchel: Remove Olivero's custom hard...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed afdff8f and pushed to 9.4.x. Thanks! Also cherry-picked to 9.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.