Problem/Motivation

Want to embed videos as background elements.

Proposed resolution

Add a new checkbox for background videos.

Remaining tasks

Add support for other providers

User interface changes

New option on field formatter form

Added an option to allow background video playback for Vimeo (https://vimeo.zendesk.com/hc/en-us/articles/115011183028-Embedding-backg...)

It may also be useful to consider an arbitrary "attributes" field to collect from site builders. Might be easier than creating individual checkboxes for everything.

CommentFileSizeAuthor
#2 3170931-background-video.patch2.88 KBminoroffense

Comments

minorOffense created an issue. See original summary.

minoroffense’s picture

minoroffense commented
StatusFileSize
new 3170931-background-video.patch2.88 KB

I added the option but I implemented it slightly differently from how the autoplay was done in YouTube. I used a DOMDocument to manipulate the markup and export it again. This could prove useful for creating more generic options like attribute manipulation. Plus it would likely be less error prone than using a regex. Especially if more complex options get added.

Let me know what you think.

minoroffense’s picture

minoroffense commented
Status: Active » Needs review

  • archnode committed d707001 on 8.x-1.x 
    Issue #3170931 by minorOffense, archnode: Add background video option
archnode’s picture

archnode commented
Status: Needs review » Fixed

This makes sense, and I share your view that a more generic approach would be more useful. As I committed a refactoring from another issue, I adapted your patch for the new structure for the time being.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.