[D8] External Logging [#3170772]

The External logging (extlog) module monitors your system and, similarly to dblog or syslog, captures system events and sends them to a remote log server.

This module allows to record events containing usage and performance data, errors, warnings, and similar operational information.

Main features are:

Configure different remote servers, like LOCAL, DEV, TEST and LIVE
Define rules to select which events should be sent to the logging server

Project link

https://www.drupal.org/project/extlog

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/extlog.git

Comments

Comment #1

14 September 2020 at 08:21

Miguelpamferreira created an issue. See original summary.

Comment #2

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 14 September 2020 at 10:40

Issue tags:

+PAreview: single application approval

Comment #3

shaktik

he/him

Hindi

New Delhi

commented 14 September 2020 at 17:08

Status:

Needs review

» Needs work

Hi @Miguelpamferreira.

Fix the Drupal coding standards.

FILE: ...cations/MAMP/htdocs/drupal/modules/extlog/extlog.permissions.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../htdocs/drupal/modules/extlog/config/install/extlog.settings.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...AMP/htdocs/drupal/modules/extlog/config/schema/extlog.schema.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Applications/MAMP/htdocs/drupal/modules/extlog/extlog.module
----------------------------------------------------------------------
FOUND 132 ERRORS AND 13 WARNINGS AFFECTING 128 LINES
----------------------------------------------------------------------
  14 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  16 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  17 | ERROR   | [x] Line indented incorrectly; expected 0 spaces,
     |         |     found 1
  25 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  26 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  27 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  28 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  29 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  30 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  31 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  32 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  32 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  33 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  33 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  34 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  34 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  35 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  35 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  36 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  36 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  37 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  37 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  38 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  38 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  39 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  39 | WARNING | [ ] Do not concatenate strings to translatable
     |         |     strings, they should be part of the t() argument
     |         |     and you should use placeholders
  40 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
  41 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  42 | WARNING | [ ] Code after RETURN statement cannot be executed
  42 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
     |         |     found 6
  44 | ERROR   | [x] Expected 1 blank line after function; 2 found
  54 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  55 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  56 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  58 | ERROR   | [x] Short array syntax must be used to define arrays
  59 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  60 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  61 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  62 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  64 | ERROR   | [x] Short array syntax must be used to define arrays
  65 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  66 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  67 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  68 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
  69 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
  70 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
  71 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
  75 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  76 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  79 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  80 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  83 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  84 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  87 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  88 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
  93 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
  93 | ERROR   | [x] Short array syntax must be used to define arrays
  94 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
  98 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
  99 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 100 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 100 | ERROR   | [x] Short array syntax must be used to define arrays
 101 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
 105 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 106 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 107 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 107 | ERROR   | [x] Short array syntax must be used to define arrays
 108 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
 110 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 113 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 114 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 115 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 118 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 119 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 120 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 124 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 125 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 126 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 127 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 128 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 129 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 130 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 135 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 136 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 137 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 138 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 139 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 140 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 143 | ERROR   | [x] Short array syntax must be used to define arrays
 144 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 145 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 146 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 147 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 148 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 149 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 151 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 14
 152 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 14
 158 | ERROR   | [x] Short array syntax must be used to define arrays
 159 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 160 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 163 | ERROR   | [x] Short array syntax must be used to define arrays
 164 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 165 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 166 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 166 | ERROR   | [x] Short array syntax must be used to define arrays
 167 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
 169 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 172 | ERROR   | [x] Short array syntax must be used to define arrays
 173 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 174 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 175 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 175 | ERROR   | [x] Short array syntax must be used to define arrays
 176 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
 178 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 181 | ERROR   | [x] Short array syntax must be used to define arrays
 182 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 183 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 184 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 184 | ERROR   | [x] Short array syntax must be used to define arrays
 185 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
 187 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 190 | ERROR   | [x] Short array syntax must be used to define arrays
 191 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 192 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 193 | ERROR   | [x] Array indentation error, expected 8 spaces but
     |         |     found 10
 199 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 200 | ERROR   | [x] Array indentation error, expected 4 spaces but
     |         |     found 6
 200 | ERROR   | [x] Short array syntax must be used to define arrays
 204 | ERROR   | [x] Expected 1 blank line after function; 2 found
 228 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
     |         |     found 4
 229 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 230 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 231 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 232 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 233 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 234 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 235 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 236 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 238 | ERROR   | [x] Expected 1 blank line after function; 2 found
 244 | ERROR   | [x] Expected "int" but found "integer" for function
     |         |     return type
 249 | ERROR   | [x] Expected 1 blank line after function; 0 found
 253 | ERROR   | [x] Expected "int" but found "integer" for function
     |         |     return type
 258 | ERROR   | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 136 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Applications/MAMP/htdocs/drupal/modules/extlog/extlog.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | WARNING | [ ] Remove "version" from the info file, it will be
   |         |     added by drupal.org packaging automatically
 7 | ERROR   | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../htdocs/drupal/modules/extlog/tests/src/Unit/ExternalLogTest.php
----------------------------------------------------------------------
FOUND 32 ERRORS AND 1 WARNING AFFECTING 25 LINES
----------------------------------------------------------------------
 14 | ERROR   | [x] Opening brace should be on the same line as the
    |         |     declaration
 15 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 18 | ERROR   | [ ] If there is no return value for a function, there
    |         |     must not be a @return tag.
 18 | ERROR   | [ ] Description for the @return value is missing
 20 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 20 | ERROR   | [x] Expected 1 blank line before function; 0 found
 21 | ERROR   | [x] Opening brace should be on the same line as the
    |         |     declaration
 22 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 23 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 30 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 34 | ERROR   | [x] Separate the @covers and @return sections by a
    |         |     blank line.
 34 | ERROR   | [ ] If there is no return value for a function, there
    |         |     must not be a @return tag.
 34 | ERROR   | [ ] Description for the @return value is missing
 36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 37 | ERROR   | [x] Opening brace should be on the same line as the
    |         |     declaration
 38 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 38 | ERROR   | [x] Inline comments must start with a capital letter
 38 | ERROR   | [x] Inline comments must end in full-stops,
    |         |     exclamation marks, colons, question marks, or
    |         |     closing parentheses
 39 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 40 | ERROR   | [x] Object operator not indented correctly; expected
    |         |     10 spaces but found 12
 41 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: 'get'
 43 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 43 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
    |         |     "TRUE" but found "true"
 45 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 46 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 48 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 50 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
    |         |     found 8
 53 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
    |         |     found 4
 53 | ERROR   | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...plications/MAMP/htdocs/drupal/modules/extlog/extlog.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ons/MAMP/htdocs/drupal/modules/extlog/src/Logger/ExternalLog.php
----------------------------------------------------------------------
FOUND 68 ERRORS AND 3 WARNINGS AFFECTING 50 LINES
----------------------------------------------------------------------
   5 | WARNING | [x] Unused use statement
  35 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
  60 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
  74 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
  78 | ERROR   | [x] Expected newline after closing brace
  84 | WARNING | [ ] Line exceeds 80 characters; contains 99
     |         |     characters
  87 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
  87 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
  87 | ERROR   | [x] Parameter comment must end with a full stop
  89 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
  90 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
  90 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
  90 | ERROR   | [x] Parameter comment must end with a full stop
  92 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
  93 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
  93 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
  93 | ERROR   | [x] Parameter comment must end with a full stop
  95 | ERROR   | [x] Expected "bool" but found "boolean" for function
     |         |     return type
  95 | ERROR   | [ ] Description for the @return value is missing
  97 | ERROR   | [ ] Private method name
     |         |     "ExternalLog::get_log_operation" is not in
     |         |     lowerCamel format
  98 | ERROR   | [x] Short array syntax must be used to define arrays
  99 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 100 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 101 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 102 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 103 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 104 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 105 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 106 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 117 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
 120 | ERROR   | [ ] Parameter $operation is not described in comment
 124 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 124 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 124 | ERROR   | [x] Parameter comment must end with a full stop
 126 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
 127 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 127 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 127 | ERROR   | [x] Parameter comment must end with a full stop
 129 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
 130 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 130 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 130 | ERROR   | [x] Parameter comment must end with a full stop
 135 | ERROR   | [ ] Private method name
     |         |     "ExternalLog::parse_log_entry" is not in
     |         |     lowerCamel format
 135 | ERROR   | [ ] Type hint "array" missing for $context
 138 | ERROR   | [x] Expected 1 space before "?"; 0 found
 146 | ERROR   | [x] Short array syntax must be used to define arrays
 147 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 148 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 149 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 150 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 151 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 152 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 156 | ERROR   | [ ] Parameter $operation is not described in comment
 157 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 160 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 160 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 160 | ERROR   | [x] Parameter comment must end with a full stop
 162 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
 163 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 163 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 163 | ERROR   | [x] Parameter comment must end with a full stop
 165 | ERROR   | [ ] Parameter tags must be grouped together in a doc
     |         |     comment
 166 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 166 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 166 | ERROR   | [x] Parameter comment must end with a full stop
 168 | ERROR   | [x] Additional blank lines found at end of doc
     |         |     comment
 169 | ERROR   | [ ] Private method name "ExternalLog::send_message"
     |         |     is not in lowerCamel format
 169 | ERROR   | [ ] Type hint "array" missing for $context
 172 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 177 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
 178 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 47 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 644ms; Memory: 10Mb

Comment #4

miguelpamferreira commented 21 September 2020 at 08:59

Status:

Needs work

» Needs review

Hello, I have applied the changes to the code on everything but the concatenation of t() functions warnings as I don't see any sensible way to make that work.

Comment #5

batkor

Irkutsk

commented 27 September 2020 at 07:19

Issue summary:

View changes

Correct dev branch.
i right changed dev branch?

Comment #6

batkor

Irkutsk

commented 27 September 2020 at 07:25

Status:

Needs review

» Needs work

Please reread code standard
https://git.drupalcode.org/project/extlog/-/blob/8.x-1.x/extlog.module#L54

Your testing your module for d9?
please remove and change deprecate code https://git.drupalcode.org/project/extlog/-/blob/8.x-1.x/extlog.module#L200

Comment #7

miguelpamferreira commented 7 October 2020 at 16:44

Status:

Needs work

» Needs review

Thank you batkor

The deprecated code in extlog.module#L200 is now fixed

Could you please be a bit more specific about what is wrong with extlog.module#L54?
I don't see anything wrong with that line

Comment #8

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2020 at 18:41

There are spaces at the end of some lines, in this code. (I added a comment at the end to show which lines have trailing spaces.)

  $form['extlog']['extlog_active'] = [ /* trailing space */
    '#type' => 'checkbox',
    '#title' => t('Active'), /* trailing space */
    '#description' => t('If active, this module will send log information to the active logger server.'), /* trailing space */
    '#default_value' => $config->get('active'),
  ];

There are other lines with trailing spaces.

There should not be trailing spaces, but I would consider that not so relevant to block an application.

Comment #9

tr commented 7 November 2020 at 22:34

Status:

Needs review

» Needs work

While there are still coding standards problems which should be fixed, there are bigger things that are wrong with this project.

Specifically, 8.x-1.1 and 8.x-1.2 and @branch are not valid branch names. Your code needs to be in the 8.x-1.x branch. Development releases like 8.x-1.x-dev will be made with the HEAD of the 8.x-1.x branch. Testing will be done against the 8.x-1.x branch. And when you are ready to make fixed-point releases, you should add a TAG for the release to the 8.x-1.x branch. So 8.x-1.5 will be a TAG on the 8.x-1.x branch, etc.

Even more confusing, you also have 8.x-1.1 and 8.x-1.2 tags on your 8.x-1.2 branch and you also have a 8.x-1.1 tag on your 8.x-1.1 branch and you also have 8.x-1.1 and 8.x-1.2 and 8.x-1.4 tags on your 8.x-1.x branch. And I'm not sure exactly what branch the 8.x-1.3 tag is attached to ... You're going to have to know a lot about git to figure out how to fix this mess. It's a real problem because if I say git checkout 8.x.1.2, what code does that give you? Git will use the tag first, rather than the branch, so if you're on the 8.x-1.1 branch it will checkout the 8.x-1.2 tag on the 8.x-1.1 branch, NOT the 8.x-1.2 branch. Likewise, there is no way of telling which branch was used to make the 8.x-1.2 release, etc.

The 8.x-1.1 and 8.x-1.2 "branches" should be deleted, but before you do that you have to make sure that the latest and best code is moved to the 8.x-1.x branch. For example, the ExternalLogger class (which I believe is the most important part of this module!) is WRONG in 8.x-1.x. It is a Unit test case in the wrong directory with the wrong namespace for that directory. And there is no ExternalLogger class implementing LoggerInterface in 8.x-1.x ! This doesn't seem to be a problem in the 8.x-1.2 "branch", just in the 8.x-1.x branch. This is also why your automated tests are failing for the 8.x-1.x branch.

Part of the confusion above with coding standards is that perhaps you are fixing them in some place other than the 8.x-1.x branch? The best thing to do is to make sure you put everything into 8.x-1.x then delete the two faulty branches. We will be glad to help you in this thread if you run into any problems - if you've made releases from one of the branches with a wrong name then you might need a drupal.org administrator to help you correct that.

Comment #10

miguelpamferreira commented 9 April 2021 at 14:00

Status:

Needs work

» Needs review

The module has been reviewed and the branches pruned.
If you would be so kind as to review once more.
Thank you

Comment #11

klausi

he/him||they/them

German

🇦🇹 Vienna

commented 6 June 2021 at 13:35

Status:	Needs review	» Fixed
Issue tags:	-PAreview: single application approval

The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722

manual review:

class ExternalLog: any reason why you manually use cURL and not Drupal's HTTP client?
extlog_form_system_logging_settings_alter(): you are showing your settings on the system logging form and not really using your "administer extlog" permission an a dedicated form, which is a bit confusing. But since that admin page requires the super admin permission "administer site configuration" anyway this is not a security issue but a normal bug.

Otherwise looks good to me!

I think we have enough code here to do a normal full project promotion.

Thanks for your contribution, Miguel!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Comment #12

20 June 2021 at 13:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

[D8] External Logging

Project link

Git instructions

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Referenced by

News items

Our community

Documentation

Drupal code base

Governance of community