The current embed dialog only allows settings custom dimensions for image media. The original image styles select was hidden.
Re-enable image styles select box and add some additional functionality:
Add additional functionality to the settings form to configure allowed image styles.
Enhance embed dialog - some cleanups and re-organize image dimensions select element.
Everything should be implemented. Needs review.
Creates a slight change in embed dialog, where additional select appears where the user can select either custom dimensions or pre-defined image styles.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff_2-5.txt | 2.1 KB | ytsurk |
| #5 | media_directories-add-embed-dialog-image-styles_5.patch | 13.23 KB | ytsurk |
Comments
Comment #2
rang501 commentedComment #3
ytsurkLooks good to me. I adopted one comment and removed the return types of the methods, are not yet a Drupalism ;)
It's also good to hide the link setting, and never allow linking the drupal-media, as it's not working. Or do you think this could be fixed .. just, does it make sense to link to content (what content that would be?) or the media entity (nobody want's that ..) - dunno if this can be configured elsewhere or will allow more options in the future ..
Comment #4
ytsurkComment #5
ytsurkUhi - there was a bug. Other then media_directories_editor settings were not saved, now all are saved again.
Comment #6
ytsurk