Needs work
Project:
Drupal core
Version:
main
Component:
jsonapi.module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Sep 2020 at 10:02 UTC
Updated:
30 May 2022 at 13:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Pooja Ganjage commentedHi,
I am applying patch for this issue.
Kindly review the patch once.
Let me know if any recommendations.
Thank.
Comment #3
Pooja Ganjage commentedComment #4
Pooja Ganjage commentedUpload interdiff for #2 patch due to an issue raised as PHPLint Failed.
Comment #5
Pooja Ganjage commentedNeeds Review.
Comment #6
bbralaHey man, thanks for contibuting! I want to wait for the linked issue to land since a few of these issues are fixed there. Is it ok if i review then?
Comment #7
Pooja Ganjage commentedYes Sure.
Comment #10
bbralaLinked patch has landed, this can be moved on ahead.
Comment #11
bbralaThis patch needs a reroll to 9.3 so work can continue.
Comment #12
bbralaComment #14
ajaypratapsingh commented#rerolled patch against drupal 9.4.x
Comment #15
ajaypratapsingh commentedComment #16
bbralaThank you for your contribution!
Unfortunately there are codestyle issues that prevent the tests from running. Click on the "PHP 7.4 & MySQL 5.7 updated deps Custom Commands Failed" to have a look at the report :)
Comment #17
ajaypratapsingh commented#remove phpcs errors from #14 patch
Comment #18
ajaypratapsingh commentedComment #19
ajaypratapsingh commentedRemoved coding styles errors which is mentioned in #17 patch
Comment #20
joachim commentedThe patch has far too many changes to review -- the whole file is in both sides of the diff, so it's impossible to see what the meaningful change is.
If there is a coding style problem such as indentation which is causing this, it should be fixed in a separate issue which fixes only that.
Comment #22
ankithashettyHave fixed the issue with #14 patch, thanks!
Comment #23
ankithashettyRe-uploading interdiff file.