Problem/Motivation

In #3036593: Add 'drupal_internal__target_id' to JSON:API representation of entity reference fields, because that can't be retrieved from the target resource for target entity types without corresponding resources it was noticed there are quite a lot of hardcoded references to id's and such for entities. Preferably this would use the real references so changes in how database id's are generate (like autoincrements) don't break the tests.

Proposed resolution

Change references to things like "uid", "target_id", "uuid" to real references.

CommentFileSizeAuthor
#23 interdiff_3169451_14-22.txt1.52 KBankithashetty
#22 3169451-22.patch21.97 KBankithashetty
#22 interdiff_3169451_14-22.patch1.52 KBankithashetty
#19 3169451-19.patch103.04 KBajaypratapsingh
#19 interdiff_17-19.txt121.85 KBajaypratapsingh
#17 3169451-17.patch24 KBajaypratapsingh
#17 interdiff_14-17.txt1.55 KBajaypratapsingh
#14 3169451-14.patch23.61 KBajaypratapsingh
#4 interdiff_2-4.txt1.33 KBPooja Ganjage
#2 3169451.patch40.21 KBPooja Ganjage

Comments

bbrala created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3169451.patch40.21 KB

Hi,

I am applying patch for this issue.

Kindly review the patch once.

Let me know if any recommendations.

Thank.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new interdiff_2-4.txt1.33 KB

Upload interdiff for #2 patch due to an issue raised as PHPLint Failed.

Pooja Ganjage’s picture

Pooja Ganjage commented

Needs Review.

bbrala’s picture

bbrala
Location Netherlands
commented

Hey man, thanks for contibuting! I want to wait for the linked issue to land since a few of these issues are fixed there. Is it ok if i review then?

Pooja Ganjage’s picture

Pooja Ganjage commented

Yes Sure.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bbrala’s picture

bbrala
Location Netherlands
commented

Linked patch has landed, this can be moved on ahead.

bbrala’s picture

bbrala
Location Netherlands
commented
Issue tags: +Needs reroll

This patch needs a reroll to 9.3 so work can continue.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Needs work

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ajaypratapsingh’s picture

ajaypratapsingh commented
StatusFileSize
new 3169451-14.patch23.61 KB

#rerolled patch against drupal 9.4.x

ajaypratapsingh’s picture

ajaypratapsingh commented
Status: Needs work » Needs review
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Needs work

Thank you for your contribution!

Unfortunately there are codestyle issues that prevent the tests from running. Click on the "PHP 7.4 & MySQL 5.7 updated deps Custom Commands Failed" to have a look at the report :)

ajaypratapsingh’s picture

ajaypratapsingh commented
StatusFileSize
new interdiff_14-17.txt1.55 KB
new 3169451-17.patch24 KB

#remove phpcs errors from #14 patch

ajaypratapsingh’s picture

ajaypratapsingh commented
Status: Needs work » Needs review
ajaypratapsingh’s picture

ajaypratapsingh commented
StatusFileSize
new interdiff_17-19.txt121.85 KB
new 3169451-19.patch103.04 KB

Removed coding styles errors which is mentioned in #17 patch

joachim’s picture

joachim commented
Status: Needs review » Needs work

The patch has far too many changes to review -- the whole file is in both sides of the diff, so it's impossible to see what the meaningful change is.

If there is a coding style problem such as indentation which is causing this, it should be fixed in a separate issue which fixes only that.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new interdiff_3169451_14-22.patch1.52 KB
new 3169451-22.patch21.97 KB

Have fixed the issue with #14 patch, thanks!

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
StatusFileSize
new interdiff_3169451_14-22.txt1.52 KB

Re-uploading interdiff file.

Status: Needs review » Needs work

The last submitted patch, 22: 3169451-22.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.