Typed_data does not currenrly have a core 9.1 build in the Travis test file. This will be useful, combined with the specified "allowed deprecations", to get an early warning of upcoming deprecations. Patch to follow.

CommentFileSizeAuthor
#2 3169262-2.travis-at-9.1.patch2.89 KBjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

Title: Update Travis to run at 9.1 with deprecations » Update Travis to run at 9.0 and 9.1 with deprecations
Status: Active » Needs review
StatusFileSize
new2.89 KB

The main changes are

-    # Allow this many deprecation warnings.
-    - SYMFONY_DEPRECATIONS_HELPER=1
+    # Initialise the real SYMFONY_DEPRECATIONS_HELPER variable.
+    - SYMFONY_DEPRECATIONS_HELPER=0
+    # Create a default for the allowed deprecations per branch.
+    - DEPRECATIONS=0

and

+    - php: 7.4
+      env:
+        - DRUPAL_CORE=9.1.x
+        # 66 Declaring ::setUp without a void return typehint
+        - DEPRECATIONS=66

and

+  # Get the allowed number of deprecation warnings.
+  - SYMFONY_DEPRECATIONS_HELPER=$DEPRECATIONS || $SYMFONY_DEPRECATIONS_HELPER
+  - echo $SYMFONY_DEPRECATIONS_HELPER

This is a clearer way to specify the number of expected deprecations per branch. Any more than this number will cause the test to fail and hence alert us (me) of the problem.

Also the build is currently broken at 9.0 due to additionally installing composer in the module directory travis_retry composer install -d $TESTDIR. This is not needed, causes problems at 9.0+ and is better removed.

The rest of the changes are just updating comments for clarity and relevance.

  • TR committed 465eece on 8.x-1.x authored by jonathan1055
    Issue #3169262 by jonathan1055: Update Travis to run at 9.0 and 9.1 with...
tr’s picture

Status: Needs review » Fixed

Committed.

jonathan1055’s picture

Thanks, this is helpful to me, and hence my contribution to the project.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.