Check and Fix the Drupal8 coding standard and Optimize the code.

CommentFileSizeAuthor
#12 autoslave_coding_standard_drupal_drupalpractice_fixes_3169075_12.patch6.82 KBvipul tulse
#12 AutoslaveController-Coding-standard-Drupal-DrupalPractice-fixes.txt6.04 KBvipul tulse
#10 3169075-10.patch11.89 KBPooja Ganjage
#4 Implement_drupal_practice_3169075.patch48.93 KBPooja Ganjage
#2 Drupal-Pratice-standard-fix.txt11.05 KBvipul tulse
#2 Drupal-coading-standard-fix.txt94.36 KBvipul tulse

Comments

vipul tulse created an issue. See original summary.

vipul tulse’s picture

vipul tulse commented
StatusFileSize
new Drupal-coading-standard-fix.txt94.36 KB
new Drupal-Pratice-standard-fix.txt11.05 KB
vipul tulse’s picture

vipul tulse commented
Issue summary: View changes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_drupal_practice_3169075.patch48.93 KB

Hi,

I am applying patch for drupal practice coding standard fixes.

Kindly review this patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
dinesh18’s picture

dinesh18 commented
Version: 8.x-3.0-alpha1 » 8.x-3.x-dev

Use this version 8.x-3.x as this is the development version with the latest code

Pooja Ganjage’s picture

Pooja Ganjage commented

Hi,

@Dinesh18, I have applied patch for 8.x-3.x version itself.

Kindly review the patch.

Thanks.

vipul tulse’s picture

vipul tulse commented

@Pooja Ganjage, for now we are not touching the Drivers

While reviewing code I found fetal php error in AutoslaveDashboardController.php

if (($this->currentUser->hasPermission('autoslave dashboard hask key')) {

You have not replaced the deprecated code drupal_set_message() function with MessengerInterface

many more issues are there, have you checked by enabling module?

vipul tulse’s picture

vipul tulse commented
Status: Needs review » Needs work
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3169075-10.patch11.89 KB

Hi,

I am applying updated patch as per the @vipul tulse reviewed results.

Review the patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
vipul tulse’s picture

vipul tulse commented
StatusFileSize
new AutoslaveController-Coding-standard-Drupal-DrupalPractice-fixes.txt6.04 KB
new autoslave_coding_standard_drupal_drupalpractice_fixes_3169075_12.patch6.82 KB

Hello,

Added the list of issues fixed with patch file, please review.

vipul tulse’s picture

vipul tulse commented
Assigned: vipul tulse » Unassigned
Status: Needs review » Closed (outdated)