Problem/Motivation

Hello, it is a very useful module for the future, there are plans to make it work in a block, the advantage of the block is that I can control where I want to use it

CommentFileSizeAuthor
#9 3168601-9.patch4.17 KBPooja Ganjage
#5 image_5.png745.04 KBobiwankenobi
#2 Implement_in_block_3168601.patch4.12 KBPooja Ganjage

Comments

Nelo_Drup created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_in_block_3168601.patch4.12 KB

Hi,

I am applying patch for implementing this module into block.

Kindly review this patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
nelo_drup’s picture

nelo_drup commented

Hi problem

Checking patch src/Plugin/Block/ConfigBlock.php...
error: src/Plugin/Block/ConfigBlock.php: No such file or directory

obiwankenobi’s picture

obiwankenobi commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new image_5.png745.04 KB

The patch doesn't apply cleanly.

I like the idea to allow the whatsapp link in other parts of the site, maybe not as a block though. Ideally we could add visibility conditions, like blocks do:

Visibility options

nelo_drup’s picture

nelo_drup commented
Title: Question module block » Bloque de módulo de preguntas

If it would be good to have more options to control the module and personally if I like the idea of ​​a block because of the fact that you can control the position also with a block you can generate classes that helps especially with the css, I hope it can be solved the patch or an update comes out

obiwankenobi’s picture

obiwankenobi commented

Oh, I like that idea. If I understand correctly, if it is used as a block, it wouldn't be a floating bubble, but part of the page (maybe
a link with an icon), so you could use in it in a "contact us" page or layout builder.

Is that what you mean?

nelo_drup’s picture

nelo_drup commented

Hello if that is the idea more or less a clearer example would be seen here https://www.drupal.org/project/facebook_mcc works more or less as I describe.
If it can function as a block, it would be enough for now, it is very useful really, this module has great potential but I do not know to what extent what I propose can be achieved

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3168601-9.patch4.17 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
cangurin limpiezas’s picture

cangurin limpiezas
Primary language English
Location Zaragoza
commented

hi @Pooja Ganjage, first thanks for your patch, i have a few doubts,
i install the patch correclty,
i can create one block for example in the sidebar (i use olivero theme)
but for default when you install "Whatsapp Bubble" module, the module create one Bubble Whatsapp.

Then if i create one block with your patch, then we have 2 Bubble Whatsapp?
or this is override?
How i can delete the default Bubble Whatsapp that for default the module created?

anyway when i create the block and put in any place and save,
i can't see block Bubble Whatsapp

many thanks

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Bloque de módulo de preguntas » Question module block
Issue tags: -Whastapp drupal 8