Problem/Motivation

The widget migration doesn't handle text_textarea_with_summary.

Steps to reproduce

Migrate a field using text_textarea_with_summary. You always end up with a migrated widget with 9 rows, which is the default value in TextareaWithSummaryWidget::defaultSettings(). This happens because we don't actually migrate this setting, and we end up using the default vlue.

Proposed resolution

Add text_textarea_with_summary, but also refactor slightly so that the defaults aren't hard coded, but rather come from the widget defaultSettings.

See also #3108302: [PP-2] Field formatter & widget settings: fall back to default if missing plugin

CommentFileSizeAuthor
#3 migrate-field_instance_widget_settings-text_textarea_with_summary-3168108-3.patch766 bytesdouggreen
#2 migrate-field_instance_widget_settings-text_textarea_with_summary--3168108-2.patch3.65 KBdouggreen

Comments

douggreen created an issue. See original summary.

douggreen’s picture

douggreen commented
Issue summary: View changes
StatusFileSize
new migrate-field_instance_widget_settings-text_textarea_with_summary--3168108-2.patch3.65 KB
douggreen’s picture

douggreen commented
StatusFileSize
new migrate-field_instance_widget_settings-text_textarea_with_summary-3168108-3.patch766 bytes

Here's a much simpler patch that changes nothing, but adds the settings for text_textarea_with_summary. ... I figured a minimal change has a higher chance of getting committed ... although I think the optimizations in the first patch are a better solution.

douggreen’s picture

douggreen commented
Status: Active » Needs review
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Category: Task » Bug report
Status: Needs review » Needs work
Issue tags: +Needs tests

This sounds like a bug, and as such requires a test proving the bug exists and that the fix fixes the issue.

quietone’s picture

quietone commented
Issue tags: +migrate-d6-d8

Is this just for D6 sources?

douggreen’s picture

douggreen commented

just adds text_textarea_with_summary, was missing

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Migrate Drupal Module was approved for removal in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3522602: [meta] Tasks to remove Migrate Drupal module and the removal work in #3522602: [meta] Tasks to remove Migrate Drupal module.

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Postponed » Closed (won't fix)

Migrate Drupal is removed from the Drupal 12 branch. Only necessary tasks, or critical or major bug fixes will be make on the Drupal 11 branch.

Therefore, this is closed as won't fix.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.