Problem/Motivation

Saving the settings in PWA Extras submodule installs a wrong configuration file pwa_extra.settings.yml instead of pwa_extra.settings.apple.yml.

Steps to reproduce

Install the submodule, export configuration.

Proposed resolution

* Rename the file in submodule's config/install folder
* correct the config schema to apply to describe pwa_extra.settings.apple configuration

CommentFileSizeAuthor
#5 1.png317.97 KBhotflowers
#5 2.png370.76 KBhotflowers
#5 3.png339.08 KBhotflowers
#3 pwa_extras_config-3167344-3.patch2.97 KBdaniel kulbe

Comments

Daniel Kulbe created an issue. See original summary.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Title: PWA Extras saves wrong configuration » PWA Extras installs wrong configuration
daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new pwa_extras_config-3167344-3.patch2.97 KB
daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Status: Active » Needs review
hotflowers’s picture

hotflowers commented
StatusFileSize
new 3.png339.08 KB
new 2.png370.76 KB
new 1.png317.97 KB

Daniel Kulbe,
Do you have the following errors?

tyler36’s picture

tyler36 commented
Status: Needs review » Reviewed & tested by the community

Confirmed:

Test:
- Install drupal:8.9
- Enable PWA: drush en pwa
- Enable PWA_extras: drush en pwa_extras
- Clear cache: drush cr
- Produces warning:

Warning: Invalid argument supplied for foreach() in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 100 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).
Drupal\Core\Render\Element\Checkboxes::valueCallback(Array, , Object)
call_user_func_array(Array, Array) (Line: 1278)
Drupal\Core\Form\FormBuilder->handleInputElement('pwa_extras_admin_settings', Array, Object) (Line: 1001)

- Export config: drush cex
- Creates: pwa_extras.settings.yml

## Fix
- Apply patch: git apply -v pwa_extras_config-3167344-3.patch.txt
- Enable PWA_extras: drush en pwa_extras
- Clear cache: drush cr
- Export config: drush cex
- Creates: pwa_extras.settings.apple.yml

alexborsody’s picture

alexborsody commented
Status: Reviewed & tested by the community » Fixed
alexborsody’s picture

alexborsody commented

alexborsody’s picture

alexborsody commented
Status: Fixed » Closed (fixed)