image

CommentFileSizeAuthor
#3 Screen Shot 2020-08-19 at 10.45.22 AM.png86.75 KBliuchanggang
#2 3166164-2.patch708 bytesliuchanggang
0ff2436b-c546-42bf-b7a2-222d541e75a8.png251.51 KBliuchanggang

Comments

liuchanggang created an issue. See original summary.

liuchanggang’s picture

liuchanggang commented
Status: Active » Needs review
StatusFileSize
new 3166164-2.patch708 bytes
liuchanggang’s picture

liuchanggang commented
StatusFileSize
new Screen Shot 2020-08-19 at 10.45.22 AM.png86.75 KB

Changed to
image

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the refactoring. I tested the patch and it looks good to me. I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 7889f10 on 8.x-1.x authored by liuchanggang 
    Issue #3166164 by liuchanggang, yas: Refactor ImageCreateForm

  • yas committed 0e449ba on 8.x-2.x authored by liuchanggang 
    Issue #3166164 by liuchanggang, yas: Refactor ImageCreateForm

  • yas committed 4affa59 on 3.x authored by liuchanggang 
    Issue #3166164 by liuchanggang, yas: Refactor ImageCreateForm
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.