Problem/Motivation

$ phpcs --standard=Drupal .

FILE: /do_username/src/Plugin/Validation/Constraint/UsernameFormatConstraint.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Missing member variable doc comment
 18 | ERROR | Missing member variable doc comment
 19 | ERROR | Missing member variable doc comment
 20 | ERROR | Missing member variable doc comment
 21 | ERROR | Missing member variable doc comment
-------------------------------------------------------------------------------------------------------------------------------


FILE: /do_username/src/Plugin/Validation/Constraint/UsernameFormatConstraintValidator.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------------------------------------------
 32 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 34 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 36 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 38 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 40 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 42 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 44 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 46 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 48 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /do_username/tests/src/Kernel/ConfigTest.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
  7 | ERROR | [ ] Missing short description in doc comment
 13 | ERROR | [x] Doc comment short description must end with a full stop
-------------------------------------------------------------------------------------------------

Proposed resolution

Fix the errors as per Drupal coding standards.

User interface changes

NONE

API changes

NONE

Data model changes

NONE

CommentFileSizeAuthor
#3 patch-do_username.png20.79 KBVarun Rao
#2 3166026-2.patch3.31 KBankithashetty

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

Status: Active » Needs review
StatusFileSize
new3.31 KB

Made the required changes as per the Drupal coding standard in the following patch file, kindly review.

Thank you!

Varun Rao’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new20.79 KB

Patch #2 applied successfully, and also free from the phpcs errors.

do

hussainweb’s picture

Thanks for the patch.

  • hussainweb committed cd5c01b on 8.x-1.x
    Issue #3166026 by ankithashetty, hussainweb: Fix Drupal Coding Standard...
hussainweb’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.