Column message "Type" need to be changed from "varchar" to "long_text" as for node whose title is too long notification widget fails to create a notification.

CommentFileSizeAuthor
#7 3166012-7.patch1.54 KBdlevchik
#4 Datatoolongforcolumnmessage-3166012-4.patch505 bytesNila Hyalij

Issue fork notificationswidget-3166012

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sudesh.solaskar created an issue. See original summary.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.4 » 8.x-1.x-dev
Assigned: sudesh.solaskar » Unassigned
Nila Hyalij’s picture

Nila Hyalij commented

Hi Sudesh,
Steps for resolving the issue.
Please visit the following path: /admin/config/system/notifications_widget
Save the configuration and issue will be resolved.

Thanks,
Nila Hyalij

Nila Hyalij’s picture

Nila Hyalij commented
Status: Active » Needs review
StatusFileSize
new Datatoolongforcolumnmessage-3166012-4.patch505 bytes

Hi,
Even if saving configuration is not solving your problem then I have added patch in which I have changed "Message" field type from "varchar" to "longtext".

Thanks,
Nila Hyalij

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

This will not fix the issue for existing installs. This would need an update hook and some proper testing to ensure there is no data loss.

dlevchik’s picture

dlevchik commented
Assigned: Unassigned » dlevchik

No changes here for a long time, I'll take that

dlevchik’s picture

dlevchik commented
StatusFileSize
new 3166012-7.patch1.54 KB

Created an update hook for that in .install, which needs review and testing.

dlevchik opened merge request !4

dlevchik’s picture

dlevchik commented
Status: Needs work » Needs review
dlevchik’s picture

dlevchik commented
Assigned: dlevchik » Unassigned
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

I think the patch should be a combination of #7 and #4 combined.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Issue tags: +Novice
sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

Let me work on this.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
Status: Needs work » Needs review
pgshehata’s picture

pgshehata commented

The patch 3166012-7.patch works for me.

sahilgidwani’s picture

sahilgidwani commented
Status: Needs review » Reviewed & tested by the community

I have checked and it works for me.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.x-dev » 2.0.x-dev

#15 You should have tested the MR (#13) as it is more complete :-)
#16 What did you test exactly? (patch or the mr)

We should also do it first on the 2.0.x version and then backport to 8.1.x but guessing because the differences are minimal it should apply rather smoothly.

chucksimply’s picture

chucksimply commented

Used MR (#13) on 2.0.0-alpha3. Works as expected.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

I also tagged 2.0.0-alpha4 to include this fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jackfoust’s picture

jackfoust commented

What is the size big on a text type? This does not install with MySQL or Maria.

Never mind I see the issue.