From #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

+++ b/core/themes/olivero/js/polyfills.es6.js
@@ -0,0 +1,16 @@
+if (window.NodeList && !NodeList.prototype.forEach) {

Let's add todo to remove this once #3143465: Add NodeList.forEach polyfill to support IE11 has landed.

CommentFileSizeAuthor
#5 3165455-5.patch395 bytessd9121
#2 3165455-2.patch419 byteskostyashupenko

Comments

mherchel created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new 3165455-2.patch419 bytes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

This should be in the @todo format, and also wrap at 80 characters. See https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/themes/claro... as an example.

sd9121’s picture

sd9121 commented
Assigned: Unassigned » sd9121
sd9121’s picture

sd9121 commented
Assigned: sd9121 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3165455-5.patch395 bytes

Please review updated patch.

  • mherchel committed 2383357 on 8.x-1.x authored by sd9121 
    Issue #3165455 by sd9121, kostyashupenko: Add @todo to remove nodeList....
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.