Closed (fixed)
Project:
Olivero
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Aug 2020 at 14:26 UTC
Updated:
24 Oct 2023 at 12:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mherchelComment #3
kostyashupenkoComment #4
mherchelReroll attached
Comment #5
mherchelI'm not too familiar with the Drupal.theme, so I might not be the best to review it, or test it. From what I can tell everything looks to be working as expected.
The one concern that I have is that we're duplicating the SVG code from
status-messages.html.twig. It might make sense to move the SVGs to external files, and reference them withimgelements, so we can be sure that the code doesn't diverge in the future.Comment #6
dunebl3 small tests on the messages... I hope it is inline with what is asked:
test1: If I clear the caches, I can see a message (cache cleared) with a closing button=>OK
test2: If I add an error in the code
$form['this_key_do_not_exists']='error';I can see a message without closing button and with the text which extends outside the dark background (Impossible to read it as it is white on white) => NOT OKtest3: If I create an element validation error (Ex: upload an xls in a widget asking for jpg) then there are NO message, which is really bad => NOT OK => see #3157576: messages color not set when error on file upload for more info on test3
Comment #7
mherchelComment #8
kostyashupenkoCan you provide more clear steps and explanations about what and where and how to reproduce?
Should be fine now. I decided to not override file.js to change messages markup. So let's keep messages for file widget without close button. Check the following styles below, this is how error messages looks right now for file widget:
Comment #9
kostyashupenkoReroll
Comment #10
mherchelTested through all messages that I could come up with, and went through the code.
I'm not too familiar with Drupal.theme(), but from what I can tell, this is perfect. If there are unresolved bugs, we can catch them in followup issues.
Comment #12
mherchelCommitted. Thank you!
Comment #14
anybody