Problem/Motivation

LICENSE.txt is copied from universal files, in general, so no need to have spelling check on them.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#12 interdiff_8_12.txt491 bytesspokje
#12 3165364-12.patch904 bytesspokje
#8 3165364-8.patch901 bytesspokje
#8 interdiff_2_8.txt1.07 KBspokje
#2 3165364-2.patch989 bytesjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Active » Needs review
StatusFileSize
new 3165364-2.patch989 bytes

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Status: Needs review » Needs work 
+++ b/core/.cspell.json
@@ -9,6 +9,9 @@
+      "lib/Drupal/Component/**/LICENSE.txt",
+      "LICENSE.txt",
+      "../composer/Plugin/**/LICENSE.txt",

Can't this be "**/LICENSE.txt" ?

ayushmishra206’s picture

ayushmishra206 commented
Assigned: Unassigned » ayushmishra206
spokje’s picture

spokje
Primary language Dutch
commented 
+++ b/core/.cspell.json
@@ -9,6 +9,9 @@
+      "lib/Drupal/Component/**/LICENSE.txt",
+      "LICENSE.txt",
+      "../composer/Plugin/**/LICENSE.txt",

Can't this be "**/LICENSE.txt" ?

Thus spoketh @quietone in #4

Would "**/LICENSE.txt" catch "LICENSE.txt"?

ayushmishra206’s picture

ayushmishra206 commented
Assigned: ayushmishra206 » Unassigned
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_2_8.txt1.07 KB
new 3165364-8.patch901 bytes

Would "**/LICENSE.txt" catch "LICENSE.txt"?

According to a test-test here: https://dispatcher.drupalci.org/job/drupal_patches/81178/console it does.
(This patch has "**/LICENSE.txt" instead of the 3 proposed lines and a unrecognizable word in /core/LICENSE.txt)

00:01:40.723 ----------------   Starting container_command.commit-checks   ----------------
00:01:40.730 Directory created at /var/lib/drupalci/workspace/jenkins-drupal_patches-81178/ancillary/container_command.commit-checks
00:01:40.730 Container command.
00:01:40.730 core/scripts/dev/commit-code-check.sh --drupalci
00:01:41.917 CSpell: Files checked: 0, Issues found: 0 in 0 files
00:01:41.935 
00:01:41.935 CSpell: passed
00:01:41.935 
00:01:41.935 ----------------------------------------------------------------------------------------------------
00:01:41.936 Checking core/.cspell.json
00:01:41.936 
00:01:41.941 core/.cspell.json passed
00:01:41.941 
00:01:41.941 ----------------------------------------------------------------------------------------------------
00:01:41.941 Checking core/LICENSE.txt
00:01:41.941 
00:01:41.945 core/LICENSE.txt passed
00:01:41.945 
00:01:41.945 ----------------------------------------------------------------------------------------------------
00:01:41.945 Checking core/misc/cspell/dictionary.txt
00:01:41.945 
00:01:41.950 core/misc/cspell/dictionary.txt passed
00:01:41.950 
00:01:41.950 ----------------------------------------------------------------------------------------------------
00:01:41.966 ---------------- Finished container_command.commit-checks in 1.243 seconds ----------------

So @quietone's suggestion works, new patch with that change attached.

quietone’s picture

quietone commented

00:01:41.941 Checking core/LICENSE.txt

@Spokje, this says cspell is checking core/LICENSE.txt instead of ignoring it. Am I wrong?

spokje’s picture

spokje
Primary language Dutch
commented

@quietone: That's the PHPCS check firing, the cspell magic happens first, at the beginning of my snippet in #8:

00:01:41.917 CSpell: Files checked: 0, Issues found: 0 in 0 files
00:01:41.935 
00:01:41.935 CSpell: passed
00:01:41.935 
00:01:41.935

(TBH: I actually thought the same when I first looked at it...)

quietone’s picture

quietone commented
Status: Needs review » Needs work

Haha! Got me there.

+++ b/core/.cspell.json
@@ -10,6 +10,7 @@
+	  "**/LICENSE.txt",

Not aligned, extra spaces.

Once that is fixed this can be RTBC

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new 3165364-12.patch904 bytes
new interdiff_8_12.txt491 bytes

Not aligned, extra spaces.

Argh, so close...

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

> CSpell: Files checked: 15192, Issues found: 0 in 0 files

Before and after applying the suggestion in #4, The number of files checked are the same. So the change is good.

Thanks!

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

@Spokje, @jungle. Thanks!

I read the patch and the whitespace is fixed, and jungle confirms this is working as expected.

  • alexpott committed 5bb2258 on 9.2.x 
    Issue #3165364 by Spokje, jungle, quietone: Ignore spelling check on...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5bb2258 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.