Hi, set this up working great really like it! Just images are downloaded in 640x425, I think maybe the search can be altered, would be nice to be able to use this to get better quality images. Thanks

CommentFileSizeAuthor
#7 interdiff_6-7.txt632 bytesdeaom
#7 3165202-7.patch9.22 KBdeaom
#6 3165202-6.patch9.17 KBnejcramsak
#6 interdiff_3-6.txt6.49 KBnejcramsak
#3 3165202-3.patch3.51 KBnejcramsak
#2 pixabay_api.png33.18 KBslogar32

Comments

zarexogre created an issue. See original summary.

slogar32’s picture

slogar32 commented
StatusFileSize
new pixabay_api.png33.18 KB

Hi! Thank you for the positive feedback, I really appreciate it. Nice suggestion, this should be made configurable and to also to get the best quality of the image through the API (api documantation in screenshot). And while we are at it, full API access support can also be made in this issue.

nejcramsak’s picture

nejcramsak commented
Status: Active » Needs review
StatusFileSize
new 3165202-3.patch3.51 KB

Hi, I created a patch for this where you can select the image size in the entity browser pixabay setup. It offers support of full API access, but if the user does not have it, it will revert to standard image size 640. Needs review.

Status: Needs review » Needs work

The last submitted patch, 3: 3165202-3.patch, failed testing. View results

zarexogre’s picture

zarexogre commented

I have tested this and works great thanks!

nejcramsak’s picture

nejcramsak commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_3-6.txt6.49 KB
new 3165202-6.patch9.17 KB

I fixed the failing test and added test functionality for the new feature.

deaom’s picture

deaom commented
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3165202-7.patch9.22 KB
new interdiff_6-7.txt632 bytes

There was just a notice present about the "Only variables should be passed by reference", because of the use of end in explode. I corrected that, so attached is a news patch. Everything else is working, so marking it as RTBC.

  • slogar32 committed 6771c06 on 8.x-1.x authored by nejcramsak 
    Issue #3165202 by nejcramsak, DeaOm, slogar32: Default setup is to...
slogar32’s picture

slogar32 commented
Status: Reviewed & tested by the community » Fixed

Thanks to everyone involved!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.