Problem/Motivation
Currently, group_notify is injecting some stuff into the e-mail body directly in group_notify_mail() and group_notify_notify(). There's all the nice plumbing of a separate view mode for what you want to see in your emails, and a twig template, but these items are hard-coded and you're stuck with them:
- 'Posted by: @author'
- 'View full post' link.
Proposed resolution
Only put the 'content' key in the message body (the rendered node or comment), and let sites configure their view mode and twig templates accordingly if they these things.
Remaining tasks
- Agree if this is wise.
- Upload the fix.
- Figure out if / how we want to warn folks during the upgrade that these items are disappearing and if they want them, they need to update their view mode config accordingly.
- Reviews / refinements.
- Commit.
User interface changes
Nothing hard-coded in email notifications. Everything is controlled by the 'group_notify_email' view modes on nodes and comments.
API changes
Not really. ;)
Data model changes
Sort of.
Comments
Comment #2
dwwThis patch will conflict with #3165156: Using Html::escape() means we can't send HTML e-mails. Happy to re-roll either one once the other lands. ;)
Comment #3
dwwIn fact, here's a very that applies cleanly after #3165156-2: Using Html::escape() means we can't send HTML e-mails is committed.
Comment #4
dww#3165156: Using Html::escape() means we can't send HTML e-mails is in, but now this conflicts with #3165324: Use Renderer::renderPlain() not render() so group_notify always works 😉
Here's a re-roll on top of #3165324...
Comment #6
gregcube commentedMakes sense to me. Committed.
Comment #7
gregcube commented