Problem/Motivation

Currently, group_notify is injecting some stuff into the e-mail body directly in group_notify_mail() and group_notify_notify(). There's all the nice plumbing of a separate view mode for what you want to see in your emails, and a twig template, but these items are hard-coded and you're stuck with them:

  • 'Posted by: @author'
  • 'View full post' link.

Proposed resolution

Only put the 'content' key in the message body (the rendered node or comment), and let sites configure their view mode and twig templates accordingly if they these things.

Remaining tasks

  1. Agree if this is wise.
  2. Upload the fix.
  3. Figure out if / how we want to warn folks during the upgrade that these items are disappearing and if they want them, they need to update their view mode config accordingly.
  4. Reviews / refinements.
  5. Commit.

User interface changes

Nothing hard-coded in email notifications. Everything is controlled by the 'group_notify_email' view modes on nodes and comments.

API changes

Not really. ;)

Data model changes

Sort of.

Comments

dww created an issue. See original summary.

dww’s picture

This patch will conflict with #3165156: Using Html::escape() means we can't send HTML e-mails. Happy to re-roll either one once the other lands. ;)

dww’s picture

Status: Active » Needs review
StatusFileSize
new1.56 KB

In fact, here's a very that applies cleanly after #3165156-2: Using Html::escape() means we can't send HTML e-mails is committed.

dww’s picture

StatusFileSize
new1.63 KB

  • gregcube committed f5f2022 on 8.x-1.x authored by dww
    Issue #3165158 by dww: Stop hard-coding any content in the email, rely...
gregcube’s picture

Makes sense to me. Committed.

gregcube’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.