Fix coding standards messages [#3164826]

Problem/Motivation

Branch 8.x-1.1 has some coding standards messages.

Steps to reproduce

Run the phpcs command to know the coding standard suggestions

Proposed resolution

Need to apply the patch file to meet the coding standards

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Comment	File	Size	Author
#6	interdiff_2-6.txt	710 bytes	urvashi_vora
#6	coding-standards-resolved-3164826-6.patch	11.68 KB	urvashi_vora
#5	patch-failed.png	63.76 KB	urvashi_vora
#2	content_connected_coding_standard_fixes-3164826-2.patch	10.51 KB	sivaprasadc

Issue fork content_connected-3164826

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3164826-fix-coding-standards changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

12 August 2020 at 14:45

SivaprasadC created an issue. See original summary.

Comment #2

sivaprasadc commented 12 August 2020 at 14:56

Assigned:	sivaprasadc	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	content_connected_coding_standard_fixes-3164826-2.patch	10.51 KB

Attached patch should fix all coding standard messages.

Comment #3

sivaprasadc commented 12 August 2020 at 15:07

Hi Team,

Before reviewing the patch, Kindly make sure you have applied this patch.

Comment #4

30 July 2022 at 07:45

urvashi_vora made their first commit to this issue’s fork.

Comment #5

urvashi_vora commented 30 July 2022 at 07:49

Assigned:	Unassigned	» urvashi_vora
Status:	Needs review	» Needs work

Status	File	Size
new	patch-failed.png	63.76 KB

Hi,

I reviewed your patch. It failed.

The output is in the screenshot. Please check.

I am working on this ticket.

Comment #6

urvashi_vora commented 30 July 2022 at 07:57

Assigned:	urvashi_vora	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	coding-standards-resolved-3164826-6.patch	11.68 KB
new	interdiff_2-6.txt	710 bytes

Hi,

Please review this patch. Also providing interdiff file. But I got this error while creating interdiff.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/content_connected-3164826$ interdiff content_connected_coding_standard_fixes-3164826-2.patch coding-standards-resolved-3164826-6.patch > interdiff_2-6.txt
1 out of 1 hunk FAILED -- saving rejects to file /tmp/interdiff-1.TscJ0V.rej
interdiff: Error applying patch1 to reconstructed file

Thanks