When we try to use this with Pager Serializer we get the following errors in the logs:

Error: Cannot use object of type stdClass as array in Drupal\rest_export_nested\Plugin\views\display\RestExportNested->render() (line 45 of modules/contrib/rest_export_nested/src/Plugin/views/display/RestExportNested.php)

Code reference snippet:

// Loop through results and fields.
    foreach ($results as $key => $result) {
      foreach ($result as $property => $value) {
        // Check if the field can be decoded using PHP's json_decode().
        if (is_string($value)) {
          if (json_decode($value) !== NULL) {
            // If so, use Guzzle to decode the JSON and add it to the results.
            $results[$key]->$property = \GuzzleHttp\json_decode($value);
          }
          elseif (json_decode(Html::decodeEntities($value)) !== NULL){
            $results[$key]->$property = \GuzzleHttp\json_decode(Html::decodeEntities($value));
          }
        }
        // Special null handling.
        if (is_string($value) && $value === 'null') {
          $results[$key]->$property = NULL;
        }
      }
    }

As soon as we switch back to Drupal core pager it works as it should.

Any help would be greatly appreciated.

CommentFileSizeAuthor
#12 3164486-12.patch2.65 KBkrzysztof domański
#12 interdiff-2-12.txt2 KBkrzysztof domański
#2 3164486-2.patch2.96 KBbluegeek9

Comments

glynster created an issue. See original summary.

bluegeek9’s picture

bluegeek9 commented
Status: Active » Needs review
StatusFileSize
new 3164486-2.patch2.96 KB

The Core Serializer returns an array of data. The Pager Serializer returns an object, and one of the properties is the same array as the Core Serializer.

I made a patch to handle the Pager Serializer.

glynster’s picture

glynster commented

@bluegeek9 thanks again for being so fast!

I applied the patch and now we get the following error:

GuzzleHttp\Exception\InvalidArgumentException: json_decode error: Syntax error in GuzzleHttp\json_decode() (line 305 of /vendor/guzzlehttp/guzzle/src/functions.php).

A small tweak?

bluegeek9’s picture

bluegeek9 commented

@glynster Do you get the same error when using the Core Searializer with this patch?

I am having trouble reproducing the error. Can you provide me with the output (json) using Pager Serializer and the Core Rest Export? I can use this for testing.

glynster’s picture

glynster commented

Hi @bluegeek9 yes indeed we were getting the same error when using the Core Serializer, funny you should ask that. It actually made all the nested views break and generated that Guzzle error. A lot of those views are only using Core Serializer.

Json output Pager Serializer with Nested just gives a white page of death.

Json with core enabled produces this:

{
rows: [
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
},
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
},
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
},
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
},
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
},
{
view: "[{"gender":"Male"},{"gender":"Female"},{"gender":"Male-identifying"},{"gender":"Female-identifying"}]"
}
],
pager: {
current_page: 0,
total_items: "211",
total_pages: 36,
items_per_page: 6
}
}

Let me know what else I can provide.

imclean’s picture

imclean commented
Related issues: +#3167577: Looking for new maintainer
imclean’s picture

imclean commented

@bluegeek9 would you be interested in becoming a maintainer?

glynster’s picture

glynster commented

@bluegeek9 checking in with you to see if you need anymore info from me for this patch?

bluegeek9’s picture

bluegeek9 commented

@glynster I was able to reproduce the bug, but I had trouble fixing it. Which module are you using for the "nested" view.

glynster’s picture

glynster commented

@bluegeek9 only Pager Serializer. However there is a small patch for core, when I tried this I got the exact same result as I do with your module: https://www.drupal.org/project/drupal/issues/2982729. Not sure if this helps but perhaps it might spark an idea?

imclean’s picture

imclean commented
Status: Needs review » Needs work 
+++ b/src/Plugin/views/display/RestExportNested.php
@@ -31,28 +31,22 @@ class RestExportNested extends display\RestExport {
+    switch ($class) {
+      case 'Drupal\pager_serializer\Plugin\views\style\PagerSerializer':
+        $rows = \Drupal::config('pager_serializer.settings')->get('rows_label');
+        $results->$rows = $this->flatten($results->$rows);
+        break;

We shouldn't be checking for the existence of a specific contrib module or class.

It might be worth looking at how Drupal core handles the situation if it works OK with Page Serializer. We need to find a more generic method of handling different return types.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Title: Pager Serializer » Does not work when rest data is an object (e.g. when Pager Serializer is enabled)
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-12.txt2 KB
new 3164486-12.patch2.65 KB

1/ We can check the $results type.

+    // The Core Serializer returns an array of rows. Custom can create an object
+    // with a 'rows' parameter.
+    if (gettype($results) === 'object') {
+      // @todo Allow rows name property to be customizable.
+      $rows = 'rows';
+      $results->$rows = $this->flatten($results->$rows);
+    }
+    else {
+      $results = $this->flatten($results);
     }

2/ As a follow-up we should allow rows name property to be customizable. However, this is not required now.

irous’s picture

irous commented

I'm testing the patch, Pager Serializer is now working with REST Export Nested for me!

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

Patch #13 works for me with REST Export Nested.

sachbearbeiter’s picture

sachbearbeiter commented

#13 works ...
Maintainers: pls. commit ...
@krzysztof-doma%C5%84ski Thanks!

sachbearbeiter’s picture

sachbearbeiter commented

Is there something evil in #12? It would be nice, if the Patch could be commited ... Thanks!

sachbearbeiter’s picture

sachbearbeiter commented

I pay some money, if you could commit this asap!

nsalves’s picture

nsalves commented

Committed the patch to the dev branch, a new release will be issued soon. Thanks guys

nsalves’s picture

nsalves commented
Status: Needs review » Fixed
sachbearbeiter’s picture

sachbearbeiter commented

@nsalves Thank you very much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

On a related note, we are getting the following error with the flatten method.

TypeError: Drupal\rest_export_nested\Plugin\views\display\RestExportNested::flatten(): Argument #1 ($data) must be of type array, null given, called in /usr/share/nginx/html/project-consumer-drupal/modules/contrib/rest_export_nested/src/Plugin/views/display/RestExportNested.php on line 45 in Drupal\rest_export_nested\Plugin\views\display\RestExportNested->flatten() (line 92 of /usr/share/nginx/html/project-consumer-drupal/modules/contrib/rest_export_nested/src/Plugin/views/display/RestExportNested.php).