Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review. Attached are three patches that came about from this review. Two of the patches attached aren't overly important - nodeforum_style.patch patches all instances of the code not found to match the Drupal coding standards (mainly to do with whitespace & comments) while nodeforum_upgradeD6_minor.patch covers all "upgrade to D6" recommendations that don't actually affect the module operation.

However, the third patch, nodeforum_upgradeD6_numrows.patch is important and not applying it could affect your module's operation. The db_num_rows() function was deprecated in Drupal 6 and should no longer be used. The attached patch fixes this. See the following link for more information on this change: http://drupal.org/node/114774#db-num-rows

Cheers,
Stella

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andrewlevine’s picture

Status: Needs review » Fixed

tested and committed

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.