Problem/Motivation

"View inclusion" condition not launched at all.

Steps to reproduce

Add condition with particular view, save context. Go to view page. Condition not launched at all.
This occurs because no view-context to condition was passed.

Proposed resolution

1. Delete view-ContextDefinition.
2. Pass view-context to condition.

I'll add patch for first resolution.

CommentFileSizeAuthor
#2 3163710-2.context.View-inclusion-condition-dont-need-viewcontext.patch647 bytessuper_romeo

Comments

super_romeo created an issue. See original summary.

super_romeo’s picture

super_romeo commented
Status: Active » Needs review
StatusFileSize
new 3163710-2.context.View-inclusion-condition-dont-need-viewcontext.patch647 bytes
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

I will have a look!
Really appreciate it :)

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

Patch #2 makes sense to me. Set to RTBC.

Thanks @super_romeo!

  • paulocs committed 040206b on 8.x-4.x authored by super_romeo 
    Issue #3163710 by super_romeo, paulocs: "View inclusion" condition don't...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed

Fixed in dev branch!

super_romeo’s picture

super_romeo commented

:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.