Problem/Motivation

If #3097907: Active toolbar tray has weak affordance and fails WCAG color criteria lands, it's going to change the default toolbar styling to invert colors on the active toolbar tray.
If this module doesn't change, it means the #fff icon will disappear against the #fff active background.

Steps to reproduce

  1. Install 9.1.x core
  2. Apply https://www.drupal.org/files/issues/2020-08-03/3097907-29.patch
  3. Install this module
  4. Shrink screen width to where the search is a tray, not rendered inline.
  5. Click on search tray.
  6. Disappearing icon.

Proposed resolution

TBD. Hopefully core will provide a class so we know what style of icon it expects.
E.g. https://www.drupal.org/files/issues/2020-08-03/3097907-32.patch
If you install that instead of 3097907-29.patch and use patch #2 from here, it works.

Remaining tasks

  1. Land #3097907: Active toolbar tray has weak affordance and fails WCAG color criteria in core.
  2. See how to handle this.
  3. Do it.

User interface changes

Hopefully: Icon will always been visible when this toolbar tray is active, regardless of core version.

API changes

N/A

CommentFileSizeAuthor
#2 3163252-2.patch1.25 KBdww

Comments

dww created an issue. See original summary.

dww’s picture

Status: Active » Needs review
StatusFileSize
new1.25 KB

Possibly like so.

dww’s picture

Issue summary: View changes
dww’s picture

Issue summary: View changes
dww’s picture

Status: Needs review » Closed (works as designed)

#3097907: Active toolbar tray has weak affordance and fails WCAG color criteria changed direction since I opened this issue, and now handles this problem without needing separate icon files to swap out. This should all Just Work(tm) now, without any special effort here.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.