Having some automated tests will help with patches and deprecation warnings.

CommentFileSizeAuthor
#18 vcard-testing-3162838-18.patch31.77 KBneograph734
#16 vcard-testing-3162838-16.patch31.38 KBneograph734
#14 vcard-testing-3162838-14.patch30.13 KBneograph734
#12 vcard-testing-3162838-12.patch29.36 KBneograph734
#10 vcard-testing-3162838-10.patch26.08 KBneograph734
#8 vcard-testing-3162838-8.patch26.08 KBneograph734
#6 vcard-testing-3162838-6.patch25.95 KBneograph734
#4 vcard-testing-3162838-4.patch25.88 KBneograph734
#2 vcard-testing-3162838-2.diff25.46 KBneograph734

Comments

Neograph734 created an issue. See original summary.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Active » Needs review
StatusFileSize
new vcard-testing-3162838-2.diff25.46 KB

Saving my first attempt here.

Status: Needs review » Needs work

The last submitted patch, 2: vcard-testing-3162838-2.diff, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-4.patch25.88 KB

Status: Needs review » Needs work

The last submitted patch, 4: vcard-testing-3162838-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-6.patch25.95 KB

Status: Needs review » Needs work

The last submitted patch, 6: vcard-testing-3162838-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-8.patch26.08 KB

Status: Needs review » Needs work

The last submitted patch, 8: vcard-testing-3162838-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-10.patch26.08 KB

Status: Needs review » Needs work

The last submitted patch, 10: vcard-testing-3162838-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-12.patch29.36 KB

Well, so much for storing my effort for now. At least the test module should now install properly, and then I can focus on finalizing the test logic later.

Status: Needs review » Needs work

The last submitted patch, 12: vcard-testing-3162838-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-14.patch30.13 KB

This should be the one.

Next step: Validate if the content from the different Zip files indeed match their input.

Status: Needs review » Needs work

The last submitted patch, 14: vcard-testing-3162838-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-16.patch31.38 KB

Status: Needs review » Needs work

The last submitted patch, 16: vcard-testing-3162838-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new vcard-testing-3162838-18.patch31.77 KB

Hmm, regular user cannot see other user's email fields due to #2799049: Add new permission to view user email field. Lets remove that part from the test then.

Status: Needs review » Needs work

The last submitted patch, 18: vcard-testing-3162838-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Neograph734 committed 199ebfa on 3.x 
    Issue #3162838 by Neograph734: Enable testing and provide one or 2 tests
neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.