EntityContextDefinition breaks the context system

Yes this works on the Travis builds at 8.8 and 8.9 and not a single deprecation message is produced. Here's a patch with adds a drupalci.yml file (not for committing) with suppress-deprecations: false just to prove on d.o. that the messages are not produced.

So how much more testing do we need to do woth this? I will use it for some manual testing, which I presume you have too. If we trust our automated tetss too, then it should be good for committing.

OK, so we have one PHPSTAN failure in #3. That implies that phpstan is not run by default on drupal.org, which is useful to know.

file name="core/src/Commands/RulesCommands.php
Class Drush\Commands\DrushCommands not found.

We should look at that separately.

Running again without PHPSTAN

OK now for the actual tests

That's good. And what's even better is that I have run the tests on Travis at Core 9.0 and everything passes. Needed the obvious changes to composer.json and rules.info.yml plus one change to tests/src/Unit/Integration/RulesEntityIntegrationTestBase.php

--- a/tests/src/Unit/Integration/RulesEntityIntegrationTestBase.php
   protected function setUp() {
     parent::setup();
 
-    require_once $this->root . '/core/includes/entity.inc';
-
     $this->namespaces['Drupal\\Core\\Entity'] = $this->root . '/core/lib/Drupal/Core/Entity';

This looks like legacy code no longer needed, and that file does not exist in D9. The tests also run at 8.8 and 8.9 without that line.

Anyway, that can be dealt with in a separate issue, to get Rules running at D9. For now, this looks OK to be committed. I'm really excited to be getting a D9 version of rules running, thank you TR for doing this work. Even if you say it yourself that it is a bad solution, it keeps us moving forward.

For info, this is the Core issue which TR is having to work around
#3126747: ContextDefinition::create() can no longer be used with an entitytype-specific datatype (like entity:user)

It's not easy to change ContextDefinition in any way and keep the tests passing - I must have tried a hundred different ways to fix this problem and none of them worked until this one.

Yes, you are right. Thanks for your persistence on this. I've been using it today, and, as you say, if the tests pass with this fairly major alteration, and we both agree that manual testing work, I say RTBC.

I have opened #3162246: Remove require_once includes/entity.inc which does not exist in D9 for the fix in #8

And that issue shows that this runs OK at D9.0

Excellent