Problem/Motivation

Views has a flag for defining that a filter plugin doesn't provide operators. Drupal\views\Plugin\views\filter\BooleanOperator is setting that to true even though the plugin provides operators. This leads to inconsistent markup.

Steps to reproduce

  • Go to /admin/structure/views/nojs/handler/frontpage/page_1/filter/status
  • Find element with .views-left-30
  • The element should be followed by another element that has class views-right-70 class, but in this case it isn't because the no_operator flag has been set

Proposed resolution

Remove the $no_operator = TRUE from Drupal\views\Plugin\views\filter\BooleanOperator.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3161199-4.patch1.54 KBlauriii
#4 3161199-4-test-only.patch943 byteslauriii
#2 3161199-2.patch629 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3161199-2.patch629 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#3161201: Deprecate $no_operator in Drupal\views\Plugin\views\filter\FilterPluginBase

Opened #3161201: Deprecate $no_operator in Drupal\views\Plugin\views\filter\FilterPluginBase to discuss removing the property.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3161199-4-test-only.patch943 bytes
new 3161199-4.patch1.54 KB

Not sure if it's worthwhile adding test coverage for this but I thought I'd go ahead and add some just to be sure.

The last submitted patch, 4: 3161199-4-test-only.patch, failed testing. View results

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

Manually confirmed the fix works and xdebugged through to see what specifically this change does. The followup I was going to request was already added in #3 👌

  • catch committed 761dbfb on 9.1.x 
    Issue #3161199 by lauriii, bnjmnm: Remove $no_operator = TRUE from Views...

  • catch committed 3e9838b on 9.0.x 
    Issue #3161199 by lauriii, bnjmnm: Remove $no_operator = TRUE from Views...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x and cherry-picked back to 8.9.x, thanks!

  • catch committed 8ef98ed on 8.9.x 
    Issue #3161199 by lauriii, bnjmnm: Remove $no_operator = TRUE from Views...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.